Open Bug 1490441 Opened 6 years ago Updated 1 year ago

Consider IC for add/sub on Date

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: evilpie, Unassigned)

References

(Blocks 1 open bug)

Details

Running Octane in the shell causes almost 50k BinaryArith failures for a JSOP_SUB where lhs and rhs are Date objects.

{
  "name":"BinaryArith",
  "file":"/home/tom/projects/inbound/js/src/octane/base.js",
  "mode":0,
  "line":308,
  "column":16,
  "pc":"7f42b68cb41e",
  "op":"sub",
  "rhs":{
    "type":"Date",
    "value":"7f42bada46c0 (shape: 7f42b428e628)"
  },
  "lhs":{
    "type":"Date",
    "value":"7f42bada9b80 (shape: 7f42b428e628)"
  }
},
Priority: -- → P3
It might make sense to first add an |Object <op> Object| stub to handle these cases with a VM call, before specializing Date :)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.