1490518 - Invalidation broken with scale transforms and SVG

Status: VERIFIED FIXED

(Core :: Web Painting, defect)

Description

[Markus Stange [:mstange]]

Attachment: testcase

Steps to reproduce:
 1. Load the attached testcase.
 2. Click anywhere on the page.

Expected results:
Only the green rectangle should remain.

Actual results:
Parts of the blue rectangle remain as well.


This was caused by bug 1462672 (verified with mozregression).


This causes glitches on the aDAU dashboard which is not publicly accessible.

Comment 1

[Miko Mynttinen]

Thank you for the reduced testcase!

Comment 2

[Miko Mynttinen]

Attachment: Bug 1490518 - Scale areas after clipping to unscaled clip

Comment 3

[Markus Stange [:mstange]]

I have applied this fix locally and confirmed that it fixes the original issue on the aDAU dashboard. Thanks!

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9009594 [details]
Bug 1490518 - Scale areas after clipping to unscaled clip

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/948e96f2b7d9
Scale areas after clipping to unscaled clip r=mattwoodrow

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/948e96f2b7d9

Comment 7

[Julien Cristau [:jcristau]]

Is this ready for uplift to beta?

Comment 8

[Miko Mynttinen]

(In reply to Julien Cristau [:jcristau] from comment #7)
> Is this ready for uplift to beta?

The attached patch does not apply cleanly due to some whitespace changes. I will post a rebased patch after the try run finishes.

Comment 9

[Miko Mynttinen]

Attachment: 1490518-beta.diff

Comment 10

[Miko Mynttinen]

Comment on attachment 9012135 [details] [diff] [review]
1490518-beta.diff

Approval Request Comment
[Feature/Bug causing the regression]: SVG elements with scale transforms are not invalidating properly, when the transform is flattened.
[User impact if declined]: Possible artifacts where the SVG was, if the scale transformed SVG changes.
[Is this code covered by automated tests?]: Yes, there is a reftest.
[Has the fix been verified in Nightly?]: Yes, I have verified the fix in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: Optional.
STR:
1) Open the attach testcase https://bug1490518.bmoattachments.org/attachment.cgi?id=9008250
2) clicking the blue box should completely hide it (with just one click)
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low risk.
[Why is the change risky/not risky?]: The fix has been in the Nightly for a week and there is a reftest. The worst case is unnecessary invalidation (and painting) with improved correctness.
[String changes made/needed]: None.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9012135 [details] [diff] [review]
1490518-beta.diff

Low risk patch for a tracked regression, approved for 63 beta 10, thanks.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f3fc62371c3

Comment 13

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2018-09-11) on Windows 10 x64.
I retested everything using the latest Nightly 64.0a1 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore. 
But I can still reproduce the issue on beta 63.0b9. I think I have to wait until beta 63.0b10 is up to verify the fix there.

Comment 14

[Oana Botisan, Desktop QA]

I verified the fix on beta 63.0b10 using Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.