1490524 - Streamline nsISHistory

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[Nicholas Nethercote [inactive]]

More shistory clean-ups.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove nsISHistory.maxLength

It's unused.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Make some nsISHistory attributes infallible

This also requires making nsISHistory `builtinclass`.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Streamline nsISHistory a little more

- Move VIEWER_WINDOW from nsISHistory to nsSHistory.

- Mark some C++-only nsISHistory methods as [noscript, notxpcom].

- Add gotoIndex() to nsISHistory so that LegacySHistoryImpl() can be removed.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Make most nsISHEntry attributes infallible

The patch also removes some NS_ENSURE_ARG_POINTER checks from these attributes'
getters. Most of these getters already lack such checks, and as long as the
infallible getters are used a non-null pointer is guaranteed. In the worst case
we'll safely null-crash anyway.

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 9008267 [details] [diff] [review]
Make most nsISHEntry attributes infallible

Actually, I have more nsISHEntry changes coming, so I'll do them in a separate bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef18a8799bf2
Remove nsISHistory.maxLength. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/783890efc3a6
Make some nsISHistory attributes infallible. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/037ca15f14dc
Streamline nsISHistory a little more. r=nika

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ef18a8799bf2
https://hg.mozilla.org/mozilla-central/rev/783890efc3a6
https://hg.mozilla.org/mozilla-central/rev/037ca15f14dc