Closed Bug 1490524 Opened Last year Closed Last year

Streamline nsISHistory

Categories

(Core :: DOM: Navigation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(3 files, 1 obsolete file)

More shistory clean-ups.
It's unused.
Attachment #9008264 - Flags: review?(nika)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
This also requires making nsISHistory `builtinclass`.
Attachment #9008265 - Flags: review?(nika)
- Move VIEWER_WINDOW from nsISHistory to nsSHistory.

- Mark some C++-only nsISHistory methods as [noscript, notxpcom].

- Add gotoIndex() to nsISHistory so that LegacySHistoryImpl() can be removed.
Attachment #9008266 - Flags: review?(nika)
The patch also removes some NS_ENSURE_ARG_POINTER checks from these attributes'
getters. Most of these getters already lack such checks, and as long as the
infallible getters are used a non-null pointer is guaranteed. In the worst case
we'll safely null-crash anyway.
Attachment #9008267 - Flags: review?(nika)
Comment on attachment 9008267 [details] [diff] [review]
Make most nsISHEntry attributes infallible

Actually, I have more nsISHEntry changes coming, so I'll do them in a separate bug.
Attachment #9008267 - Attachment is obsolete: true
Attachment #9008267 - Flags: review?(nika)
Summary: Streamline nsISHistory and nsISHEntry → Streamline nsISHistory
Attachment #9008264 - Flags: review?(nika) → review+
Attachment #9008265 - Flags: review?(nika) → review+
Attachment #9008266 - Flags: review?(nika) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef18a8799bf2
Remove nsISHistory.maxLength. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/783890efc3a6
Make some nsISHistory attributes infallible. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/037ca15f14dc
Streamline nsISHistory a little more. r=nika
You need to log in before you can comment on or make changes to this bug.