Closed
Bug 1490524
Opened 6 years ago
Closed 6 years ago
Streamline nsISHistory
Categories
(Core :: DOM: Navigation, enhancement)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(3 files, 1 obsolete file)
|
2.39 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
6.16 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
14.15 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
More shistory clean-ups.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
This also requires making nsISHistory `builtinclass`.
Attachment #9008265 -
Flags: review?(nika)
|
|
Assignee | |
Comment 3•6 years ago
|
||
- Move VIEWER_WINDOW from nsISHistory to nsSHistory. - Mark some C++-only nsISHistory methods as [noscript, notxpcom]. - Add gotoIndex() to nsISHistory so that LegacySHistoryImpl() can be removed.
Attachment #9008266 -
Flags: review?(nika)
|
|
Assignee | |
Comment 4•6 years ago
|
||
The patch also removes some NS_ENSURE_ARG_POINTER checks from these attributes' getters. Most of these getters already lack such checks, and as long as the infallible getters are used a non-null pointer is guaranteed. In the worst case we'll safely null-crash anyway.
Attachment #9008267 -
Flags: review?(nika)
|
|
Assignee | |
Comment 5•6 years ago
|
||
Comment on attachment 9008267 [details] [diff] [review] Make most nsISHEntry attributes infallible Actually, I have more nsISHEntry changes coming, so I'll do them in a separate bug.
Attachment #9008267 -
Attachment is obsolete: true
Attachment #9008267 -
Flags: review?(nika)
|
|
Assignee | |
Updated•6 years ago
|
Summary: Streamline nsISHistory and nsISHEntry → Streamline nsISHistory
|
||
Updated•6 years ago
|
Attachment #9008264 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #9008265 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #9008266 -
Flags: review?(nika) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef18a8799bf2 Remove nsISHistory.maxLength. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/783890efc3a6 Make some nsISHistory attributes infallible. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/037ca15f14dc Streamline nsISHistory a little more. r=nika
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ef18a8799bf2 https://hg.mozilla.org/mozilla-central/rev/783890efc3a6 https://hg.mozilla.org/mozilla-central/rev/037ca15f14dc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•