Closed Bug 1490525 Opened 6 years ago Closed 6 years ago

Unbitrot reflow logs in nsColumnSetFrame

Categories

(Core :: Layout: Columns, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(3 files)

nsColumnSetFrame has some reflow logs in DEBUG_roc. I find them quite handy when debugging column reflow. I'd like to unbitrot them and make them more accessible by using MOZ_LOG.
This does Bug 1464967 Part 2 in a different way by using mozilla::ToString()
to dump nsReflowStatus.
Since bug 775624, nsReflowStatus has become a class, not an integer. We need
to expose operator<<() for nsReflowStatus to non-debug build to dump
nsReflowStatus's content in MOZ_LOG.

Depends on 5634
Verified locally by s/UNIFIED_SOURCES/SOURCES/ in layout/generic/moz.build.

Depends on 5635
Comment on attachment 9008280 [details]
Bug 1490525 Part 1 - Remove nsReflowStatus::ToString()

Cameron McCormack (:heycam) has approved the revision.
Attachment #9008280 - Flags: review+
Comment on attachment 9008282 [details]
Bug 1490525 Part 3 - Remove unused #includes in nsColumnSetFrame.cpp

Daniel Holbert [:dholbert] has approved the revision.
Attachment #9008282 - Flags: review+
Comment on attachment 9008281 [details]
Bug 1490525 Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG

Daniel Holbert [:dholbert] has approved the revision.
Attachment #9008281 - Flags: review+
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/11b66d57623b
Part 1 - Remove nsReflowStatus::ToString() r=heycam
https://hg.mozilla.org/integration/autoland/rev/69658275272a
Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG r=dholbert
https://hg.mozilla.org/integration/autoland/rev/2ca4150b4f77
Part 3 - Remove unused #includes in nsColumnSetFrame.cpp r=dholbert
https://hg.mozilla.org/mozilla-central/rev/11b66d57623b
https://hg.mozilla.org/mozilla-central/rev/69658275272a
https://hg.mozilla.org/mozilla-central/rev/2ca4150b4f77
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: