1490525 - Unbitrot reflow logs in nsColumnSetFrame

Status: RESOLVED FIXED

(Core :: Layout: Columns, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

nsColumnSetFrame has some reflow logs in DEBUG_roc. I find them quite handy when debugging column reflow. I'd like to unbitrot them and make them more accessible by using MOZ_LOG.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1490525 Part 1 - Remove nsReflowStatus::ToString()

This does Bug 1464967 Part 2 in a different way by using mozilla::ToString()
to dump nsReflowStatus.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1490525 Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG

Since bug 775624, nsReflowStatus has become a class, not an integer. We need
to expose operator<<() for nsReflowStatus to non-debug build to dump
nsReflowStatus's content in MOZ_LOG.

Depends on 5634

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1490525 Part 3 - Remove unused #includes in nsColumnSetFrame.cpp

Verified locally by s/UNIFIED_SOURCES/SOURCES/ in layout/generic/moz.build.

Depends on 5635

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 9008280 [details]
Bug 1490525 Part 1 - Remove nsReflowStatus::ToString()

Cameron McCormack (:heycam) has approved the revision.

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 9008282 [details]
Bug 1490525 Part 3 - Remove unused #includes in nsColumnSetFrame.cpp

Daniel Holbert [:dholbert] has approved the revision.

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 9008281 [details]
Bug 1490525 Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG

Daniel Holbert [:dholbert] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11b66d57623b
Part 1 - Remove nsReflowStatus::ToString() r=heycam
https://hg.mozilla.org/integration/autoland/rev/69658275272a
Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG r=dholbert
https://hg.mozilla.org/integration/autoland/rev/2ca4150b4f77
Part 3 - Remove unused #includes in nsColumnSetFrame.cpp r=dholbert

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/11b66d57623b
https://hg.mozilla.org/mozilla-central/rev/69658275272a
https://hg.mozilla.org/mozilla-central/rev/2ca4150b4f77