1490539 - Some cleanup for fullscreen stuff

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P5)

Description

[Xidorn Quan [:xidorn] UTC+10]

Canonicalize naming from FullScreen to Fullscreen in DOM code, and moving some stuff around, probably.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1490539 part 1 - Change FullScreen to Fullscreen in various names. r=smaug

Some methods on Window are not changed because they are part of public
interface. Method names from widget are also unchanged.

Many "full-screen" in comments are also updated to "fullscreen" instead.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1490539 part 2 - Remove unnecessary && from UniquePtr<FullscreenRequest>. r=smaug

We only do unconditional move for FullscreenRequest, so the &&s are
pointless, based on guidance of UniquePtr.

Depends on D5639

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1490539 part 3 - Put CallerType into FullscreenRequest. r=smaug

Depends on D5640

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9008299 [details]
Bug 1490539 part 1 - Change FullScreen to Fullscreen in various names. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9008300 [details]
Bug 1490539 part 2 - Remove unnecessary && from UniquePtr<FullscreenRequest>. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9008301 [details]
Bug 1490539 part 3 - Put CallerType into FullscreenRequest. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/362b50acb496
part 1 - Change FullScreen to Fullscreen in various names. r=smaug
https://hg.mozilla.org/integration/autoland/rev/271080013cac
part 2 - Remove unnecessary && from UniquePtr<FullscreenRequest>. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b5a091992f08
part 3 - Put CallerType into FullscreenRequest. r=smaug

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/362b50acb496
https://hg.mozilla.org/mozilla-central/rev/271080013cac
https://hg.mozilla.org/mozilla-central/rev/b5a091992f08

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/645939049d7e
followup - Get document of fullscreen request in a separate step for fixing failures on non-clang builds. a=tier2-permafail-fix