Closed
Bug 1490539
Opened 6 years ago
Closed 6 years ago
Some cleanup for fullscreen stuff
Categories
(Core :: DOM: Core & HTML, enhancement, P5)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Canonicalize naming from FullScreen to Fullscreen in DOM code, and moving some stuff around, probably.
Assignee | ||
Comment 1•6 years ago
|
||
Some methods on Window are not changed because they are part of public interface. Method names from widget are also unchanged. Many "full-screen" in comments are also updated to "fullscreen" instead.
Assignee | ||
Comment 2•6 years ago
|
||
We only do unconditional move for FullscreenRequest, so the &&s are pointless, based on guidance of UniquePtr. Depends on D5639
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D5640
Comment 4•6 years ago
|
||
Comment on attachment 9008299 [details] Bug 1490539 part 1 - Change FullScreen to Fullscreen in various names. r=smaug Olli Pettay [:smaug] has approved the revision.
Attachment #9008299 -
Flags: review+
Comment 5•6 years ago
|
||
Comment on attachment 9008300 [details] Bug 1490539 part 2 - Remove unnecessary && from UniquePtr<FullscreenRequest>. r=smaug Olli Pettay [:smaug] has approved the revision.
Attachment #9008300 -
Flags: review+
Comment 6•6 years ago
|
||
Comment on attachment 9008301 [details] Bug 1490539 part 3 - Put CallerType into FullscreenRequest. r=smaug Olli Pettay [:smaug] has approved the revision.
Attachment #9008301 -
Flags: review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/362b50acb496 part 1 - Change FullScreen to Fullscreen in various names. r=smaug https://hg.mozilla.org/integration/autoland/rev/271080013cac part 2 - Remove unnecessary && from UniquePtr<FullscreenRequest>. r=smaug https://hg.mozilla.org/integration/autoland/rev/b5a091992f08 part 3 - Put CallerType into FullscreenRequest. r=smaug
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/362b50acb496 https://hg.mozilla.org/mozilla-central/rev/271080013cac https://hg.mozilla.org/mozilla-central/rev/b5a091992f08
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Pushed by xquan@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/645939049d7e followup - Get document of fullscreen request in a separate step for fixing failures on non-clang builds. a=tier2-permafail-fix
You need to log in
before you can comment on or make changes to this bug.
Description
•