Closed
Bug 1490556
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 12960 - [css-contain] Fix contain-size-025 using "dislay: block" on images
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12960 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/12960
Details from upstream follow.
Manuel Rego Casasnovas <rego@igalia.com> wrote:
> [css-contain] Fix contain-size-025 using "dislay: block" on images
>
> The test was overflowing in Chromium in some configurations,
> because of the images were sitting on the alphabetic baseline
> and it varies depending on the font the browser selects.
> The test was trying to avoid the issue by using a 50x23 image,
> however that was not enough in some cases.
>
> The test is modified so it uses "display: block" for the images
> and 50x25 as size for them.
> This was discussed offline with @TalbotG.
| Assignee | ||
Updated•7 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
| Assignee | ||
Comment 1•7 years ago
|
||
| Assignee | ||
Comment 2•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=433bd9e258b198d4b825db7b95ff39bd1e4edc70
| Assignee | ||
Comment 3•7 years ago
|
||
Ran 1 tests
PASS : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6987c8648d0
[wpt PR 12960] - [css-contain] Fix contain-size-025 using "dislay: block" on images, a=testonly
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 6•7 years ago
|
||
Backed out for WPT mass failure at /fullscreen/idlharness.window.html
Backout: https://hg.mozilla.org/mozilla-central/rev/e1a681345945ab8c8b8270afcd2f62bf042226c2
Failure push:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=be6801cdeb537afa655bbd67d12ead8dc01c6c38
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3f3f67d1c0bf5359ac39ddddec5999ceb928e7ca
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199470643&repo=mozilla-central&lineNumber=1487
Status: RESOLVED → REOPENED
status-firefox64:
fixed → ---
Flags: needinfo?(james)
Resolution: FIXED → ---
Target Milestone: mozilla64 → ---
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d14eab012dae
[wpt PR 12960] - [css-contain] Fix contain-size-025 using "dislay: block" on images, a=testonly
Comment 8•7 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•7 years ago
|
Flags: needinfo?(james)
You need to log in
before you can comment on or make changes to this bug.
Description
•