Closed
Bug 1490593
Opened 6 years ago
Closed 5 years ago
Move FFI bindings for encoding_rs::mem from encoding_glue to a dedicated crate
Categories
(Core :: Internationalization, enhancement, P3)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
encoding_glue is a Gecko-only crate. Currently, there are ad hoc FFI bindings for encoding_rs::mem there. encoding_c should gain non-ad hoc FFI bindings for encoding_rs::mem in order to make encoding_rs::mem available to standalone SpiderMonkey.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
Let's introduce a new crate encoding_c_mem for this in order to enable nicer LTO scenarios.
Summary: Move FFI bindings for encoding_rs::mem from encoding_glue to encoding_c → Move FFI bindings for encoding_rs::mem from encoding_glue to a dedicated crate
|
|
Assignee | |
Comment 2•5 years ago
|
||
Also remove C++-side optimizations for avoiding calls to Rust for
short strings now that we have LTO between C++ and Rust.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3f2cf3e1bb4 Move FFI for encoding_rs::mem to a vendored crate. r=froydnj
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•