Closed
Bug 1490617
Opened 6 years ago
Closed 6 years ago
CaptivePortalWatcher reads the captivedetect.portalRecheckDelayMS pref before being initialized
Categories
(Firefox :: General, enhancement, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
2.13 KB,
patch
|
nhnt11
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #9008356 -
Flags: review?(nhnt11)
|
||
Comment 1•6 years ago
|
||
Comment on attachment 9008356 [details] [diff] [review] patch Review of attachment 9008356 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching this, I'm not sure why this was not removed when the lazy pref getter was added (it was changed to use Services.prefs instead of Preferences.get).
Attachment #9008356 -
Flags: review?(nhnt11) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6385467d93ce CaptivePortalWatcher reads the captivedetect.portalRecheckDelayMS pref before being initialized. r=nhnt11
|
||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6385467d93ce - landed 22 hours ago
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•