1490622 - /sources/highlight/ page should highlight the line number specified in the anchor

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[(not currently active) Ted Mielczarek]

A minor nit, but I clicked a source link from a crash report that led to a /sources/highlight/ page:
https://crash-stats.mozilla.com/sources/highlight/?url=https://gecko-generated-sources.s3.amazonaws.com/012d596d312520f1955f9a4bfe2b3746677b792aa9a98b6c1ff4603c09239ad8b35e2654d4bf8baebe3e74bfd62460ab87a8eae6ca9e7146bd081ab677671bd7/dom/bindings/MessageManagerBinding.cpp#L-6637

and it wasn't readily apparent what the actual line in question was. Compare vs. a link to hg.mo from the same crash report:
https://hg.mozilla.org/mozilla-central/annotate/1169e8a4ca2b7f3cbffdaf70f6d18a5142ed32d7/toolkit/xre/nsWindowsWMain.cpp#l143

There you can see the line that was linked to is clearly highlighted. It would be nice if we did the same thing on the /sources/highlight/ page.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 to try to get to.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/39dbd63774da49ee61d899ae66f1653e8c3ea8f1
fix bug 1490622: add values for memory_error_correction

https://github.com/mozilla-services/socorro/commit/513f104e8fca04a92bdc158d93749320631f1c21
Merge pull request #4592 from willkg/1490662-memoryerrorcorrection-values

fix bug 1490622: add values for memory_error_correction

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--landed a fix for a different bug with the wrong number in the commit. Sorry!

Comment 4

[Osmose [:osmose, :mkelly]]

Attachment: Screen Shot 2019-01-11 at 5.53.17 PM.png

I have a patch that adds line highlighting, but the default style has rather... weak highlighting. Should we bother modifying the style, chosing a different style, or should we just go with this?

Comment 5

[Osmose [:osmose, :mkelly]]

I'm gonna put this patch up and we can tweak it later if it's still an issue.

Comment 6

[(not currently active) Ted Mielczarek]

I think that's strictly an improvement over what we have now. Is there a way to make the line number itself also be highlighted? (Not a dealbreaker but seems like it'd be useful.) Thanks for taking this!

Comment 7

[Osmose [:osmose, :mkelly]]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #6)

I think that's strictly an improvement over what we have now. Is there a way to make the line number itself also be highlighted? (Not a dealbreaker but seems like it'd be useful.) Thanks for taking this!

Not without getting too deep into pygments customization, sadly.

Comment 8

[Osmose [:osmose, :mkelly]]

Attachment: pr 4778: Fix bug 1490622: Highlight linked line when coloring source code.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/a17131751316e8bed00c1ccde9e6d839e005c1ba
Fix bug 1490622: Highlight linked line when coloring source code.

The original tests for this view did not run anymore due to the testcase class
name not starting with the word "Test", so this also removes the class and
refactors the tests to run under pytest.

https://github.com/mozilla-services/socorro/commit/2a0284884b3cf454ef457bab683e383dcf47eb39
Merge pull request #4778 from Osmose/highlight-line

Fix bug 1490622: Highlight linked line when coloring source code.