1490654 - Drop support for MSVC 2017 Update 6

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, enhancement)

Description

[Masatoshi Kimura [:emk]]

MSVC 15.6 make it impossible to fix some bugs such as bug 1415980 and bug 1449787.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Drop support for MSVC 2017 Update 6

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 9009458 [details] [diff] [review]
Drop support for MSVC 2017 Update 6

Review of attachment 9009458 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for keeping us up-to-date with MSVC!

::: python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py
@@ +903,5 @@
>  
>      VS_2013u2_RESULT = (
>          'This version (18.00.30501) of the MSVC compiler is not supported.\n'
> +        'You must install Visual C++ 2017 Update 8 or later in order to'
> +        ' build.\n'

Maybe we should have a:

VS_FAILURE_MESSAGE = 'This version (%s) of the MSVC compiler is not...'

and then all of these would just be:

VS_2013u2_RESULT = VS_FAILURE_MESSAGE % '18.00.30501'

WDYT?

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Drop support for MSVC 2017 Update 6

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 9009780 [details] [diff] [review]
Drop support for MSVC 2017 Update 6

Carrying forward.

(In reply to Nathan Froyd [:froydnj] from comment #2)
> Maybe we should have a:
> 
> VS_FAILURE_MESSAGE = 'This version (%s) of the MSVC compiler is not...'
> 
> and then all of these would just be:
> 
> VS_2013u2_RESULT = VS_FAILURE_MESSAGE % '18.00.30501'
> 
> WDYT?

I concur.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa0aed5cb503
Drop support for MSVC 2017 Update 6. r=froydnj

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/aa0aed5cb503