Closed Bug 1490654 Opened 3 years ago Closed 3 years ago

Drop support for MSVC 2017 Update 6

Categories

(Firefox Build System :: Toolchains, enhancement)

enhancement
Not set
normal

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file, 1 obsolete file)

MSVC 15.6 make it impossible to fix some bugs such as bug 1415980 and bug 1449787.
Attachment #9009458 - Flags: review?(core-build-config-reviews)
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 9009458 [details] [diff] [review]
Drop support for MSVC 2017 Update 6

Review of attachment 9009458 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for keeping us up-to-date with MSVC!

::: python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py
@@ +903,5 @@
>  
>      VS_2013u2_RESULT = (
>          'This version (18.00.30501) of the MSVC compiler is not supported.\n'
> +        'You must install Visual C++ 2017 Update 8 or later in order to'
> +        ' build.\n'

Maybe we should have a:

VS_FAILURE_MESSAGE = 'This version (%s) of the MSVC compiler is not...'

and then all of these would just be:

VS_2013u2_RESULT = VS_FAILURE_MESSAGE % '18.00.30501'

WDYT?
Attachment #9009458 - Flags: review?(core-build-config-reviews) → review+
Attachment #9009458 - Attachment is obsolete: true
Comment on attachment 9009780 [details] [diff] [review]
Drop support for MSVC 2017 Update 6

Carrying forward.

(In reply to Nathan Froyd [:froydnj] from comment #2)
> Maybe we should have a:
> 
> VS_FAILURE_MESSAGE = 'This version (%s) of the MSVC compiler is not...'
> 
> and then all of these would just be:
> 
> VS_2013u2_RESULT = VS_FAILURE_MESSAGE % '18.00.30501'
> 
> WDYT?

I concur.
Attachment #9009780 - Flags: review+
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa0aed5cb503
Drop support for MSVC 2017 Update 6. r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/aa0aed5cb503
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
No longer blocks: 1415980
You need to log in before you can comment on or make changes to this bug.