1490674 - Upgrade log crate to 0.4

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

There are various different pieces of code spread throughout that
depend on log 0.3 and they should all be upgraded to 0.4 so that
we can drop the vendored 0.3.9 crate.

I discovered that attempting to run "cargo update -p webdriver"
would upgrade _other crates’_ log version because of some suboptimal
dependency definitions.  I will fix all of these so that running
"cargo update -p <whatever>" wouldn’t cause changes in unrelated
crates.

Comment 1

[Andreas Tolfsen ❲:ato❳]

There’s apparently a dependency in audioipc on tokio-uds 0.1.7, and
this particular version of tokio-uds depends on log 0.3.  This means
the patches I will be attaching here does not end up removing log
0.3.9 from the tree, but paves the way for doing so, once audioipc
updates their tokio-uds to 0.2, which depends on log 0.4.  I will
file a follow-up bug on this in the WebRTC component later.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: js/binsource: relax log crate dependency version

Relax the dependency on log to include any 0.4.* version of log.
This enables us to get rid of duplicate vendored crates.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: audioipc: relax log crate dependency version

By relaxing the version dependency on the log crate we are able to
get rid of duplicate vendored crates.

This particular version number, combined with rsdparsa depending
on "*" (anything) meant that a change to this version number in
audioipc would have reprecussions on the dependencies of rsdparsa.
I will address the wildcard version in a separate patch on rsdparsa.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: rsdparsa: relax log crate dependency version

Because all Rust crates in the tree are vendored, using the wildcard
"*" version dependency could have unintended reprecussions on
rsdparsa if another crate changes its log version dependency.

This patch, along with the others associated with this bug, upgrades
the log crate to 0.4.* throughout.  This has the benefit that we
can get rid of the duplicate vendored log crates in third_party/rust.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: upgrade to log 0.4.5

log 0.3.9 is still there because tokio-uds 0.1.7, which is a
dependency of audioipc, still depends on ^0.3.  A separate bug will
be filed on WebRTC to upgrade their tokio-uds dependency.

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: vendor rust dependencies

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 9008436 [details] [diff] [review]
upgrade to log 0.4.5

Review of attachment 9008436 [details] [diff] [review]:
-----------------------------------------------------------------

Yes please, and thank you!

Comment 8

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=39695c5799edb101123d1ba73656e2ba6f8d8ff8

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 9008430 [details] [diff] [review]
js/binsource: relax log crate dependency version

Review of attachment 9008430 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds like a good idea.

Comment 10

[Nils Ohlmeier [:drno]]

Comment on attachment 9008434 [details] [diff] [review]
rsdparsa: relax log crate dependency version

Review of attachment 9008434 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/372ef97247a0
js/binsource: relax log crate dependency version; r=Yoric
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b01b1ef8e8a
audioipc: relax log crate dependency version; r=kamidphish
https://hg.mozilla.org/integration/mozilla-inbound/rev/e682647d08a2
rsdparsa: relax log crate dependency version; r=drno
https://hg.mozilla.org/integration/mozilla-inbound/rev/f80135589b9b
upgrade to log 0.4.5; r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/362b43ebdc0a
vendor rust dependencies; r=me

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/372ef97247a0
https://hg.mozilla.org/mozilla-central/rev/7b01b1ef8e8a
https://hg.mozilla.org/mozilla-central/rev/e682647d08a2
https://hg.mozilla.org/mozilla-central/rev/f80135589b9b
https://hg.mozilla.org/mozilla-central/rev/362b43ebdc0a