1490697 - The CFR shield study wrongly works on Firefox locales other than EN-US

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:
- According to the PHD the CFR shield study should work only on the EN-US Firefox locale.

[Affected versions]:
- Firefox 63 and above

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a Firefox locale build other than EN-US installed (eg. RO).
- Have a Firefox profile with the following prefs in the "about:config" page:
	- "browser.newtabpage.activity-stream.asrouterExperimentEnabled" with "true" value;
	- "devtools.chrome.enabled" on true.
- Have the "Browser Console" opened.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the "YouTube" Top Site.
3. Repeat step 2 another 4 times and restart the browser.
4. Navigate to the "youtube.com" website in a new tab and observe the behavior.

[Expected result]:
- The "CFR" recommendation button is not displayed for this region.

[Actual result]:
- The "CFR" recommendation button is displayed in the right part of the "Address Bar.

[Additional Notes]:
- This issue is also reproducible with the "Facebook", "Google Translate", "Wikipedia" and "Reddit" websites.
- Attached a screen recording of the issue.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4449

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/910affd171fe8c080255f877b7876d52343fe8de
Bug 1490697 - Support filtering by locale in ASR/CFR

Comment 4

[Kate Hudson :k88hudson]

We have decided this does not require uplift since we are only running a shield study in 63, which can filter on locale.

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Marking this as Resolved - Fixed as it was fixed by bug 1494427.

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest version of "Firefox Nightly" (64.0a1 - Build ID 20181001220118) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "CFR Recommendation" is no longer displayed on Firefox locales other than EN-US.

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/410ea4b30b37