1490730 - [css-grid] Static position should use content-box, not padding-box

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P3)

Description

[Mats Palmgren (inactive)]

This is a recent CSS Grid spec change:
"[css-grid] Static position should use content-box, not padding-box"
https://github.com/w3c/csswg-drafts/issues/3020

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

Comment 2

[Mats Palmgren (inactive)]

Attachment: test reference updates (modulo WPT)

Comment 3

[Mats Palmgren (inactive)]

There's also a bunch of WPT failures in
testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b63011db669c776e62166a6044b572d21bcbafe&selectedJob=199164499
(which are duplicates of the reftests I fixed above)

It seems "./mach wpt-update wpt_raw.log" doesn't work for me anymore though...

Can you double-check if it works for you in case it's something local?

Comment 4

[Mats Palmgren (inactive)]

Nevermind, I see what happened now.

Comment 5

[Mats Palmgren (inactive)]

Attachment: old WPT tests expected to fail now

I guess marking these as failing for now until we sync the updated
tests is the way to go?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df4e19315cd3
part 1 - [css-grid] Static position should use content-box, not padding-box.  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/69980706914c
part 2 - [css-grid] Static position should use content-box, not padding-box.  Test reference updates.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5c0ba4149fe
part 3 - [css-grid] Static position should use content-box, not padding-box.  WPT updates.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13014 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/df4e19315cd3
https://hg.mozilla.org/mozilla-central/rev/69980706914c
https://hg.mozilla.org/mozilla-central/rev/e5c0ba4149fe

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13014
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/JwRjWUyzSKe7fiu8GPnjMA)

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

web-platform-tests PR at https://github.com/web-platform-tests/wpt/pull/13022