Closed Bug 1490730 Opened Last year Closed Last year

[css-grid] Static position should use content-box, not padding-box

Categories

(Core :: Layout: Grid, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mats, Assigned: mats)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

This is a recent CSS Grid spec change:
"[css-grid] Static position should use content-box, not padding-box"
https://github.com/w3c/csswg-drafts/issues/3020
Assignee: nobody → mats
Attached patch fixSplinter Review
Attachment #9008956 - Flags: review?(dholbert)
There's also a bunch of WPT failures in
testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b63011db669c776e62166a6044b572d21bcbafe&selectedJob=199164499
(which are duplicates of the reftests I fixed above)

It seems "./mach wpt-update wpt_raw.log" doesn't work for me anymore though...

Can you double-check if it works for you in case it's something local?
Flags: needinfo?(dholbert)
Nevermind, I see what happened now.
Flags: needinfo?(dholbert)
I guess marking these as failing for now until we sync the updated
tests is the way to go?
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df4e19315cd3
part 1 - [css-grid] Static position should use content-box, not padding-box.  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/69980706914c
part 2 - [css-grid] Static position should use content-box, not padding-box.  Test reference updates.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5c0ba4149fe
part 3 - [css-grid] Static position should use content-box, not padding-box.  WPT updates.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13014 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13014
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/JwRjWUyzSKe7fiu8GPnjMA)
Flags: in-testsuite+
Blocks: 1500622
You need to log in before you can comment on or make changes to this bug.