1490739 - When two spelling dictionaries with the same name are installed, you can't pick between them

Status: NEW

(Core :: Spelling checker, defect, P5)

Description

[Darxus]

Attachment: firefoxboth.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180905221508

Steps to reproduce:

Start with English language pack and dictionary.  Add German dictionary.  Disable English language pack and dictionaries.  Enable German dictionary.  Type English and German words.


Actual results:

Spellchecker said English word was correct, and German word was not.  Meaning changing spellchecker languages didn't work.


Expected results:

Spellchecker should've said English word was wrong, and German word was correct.

Comment 1

[Darxus]

I failed to mention that I did try restarting firefox, that didn't help.

Comment 2

[Darxus]

I also tried disabling all my extensions, and restarting.  No improvement.

Comment 3

[Timea Cernea [:tbabos][inactive]]

Hi Darxus,

The default spell checker language is English, so the word will always be checked first using the default integrated English Dictionary. 
If you have other languages installed (in your case German) please make sure to enable the language pack and select it via the Context Menu option. It will correctly spell check all that you wrote before and was highlighted as incorrect.
Here is an example of how to do that: https://streamable.com/p8lq0

Please tell me if this solves the issue or if I missed something.

Thanks

Comment 4

[Darxus]

I am now able to switch from English to German (I was not changing the language via the context menu).  

But I still can't do what I want to do.  Should I open a new bug?  Take this to the support-firefox@ list?

I've created (and installed) my own English (US) dictionary, based on the integrated one, with a few words removed.  It looks like I can't ever select my dictionary, because I can't disable the integrated English dictionary, and they are both en-US?  In the context menu, I only see the one "English (United States)" option.  

So it looks to me like there's a bug preventing me from switching to any other dictionary with the same locale (en-US) as the integrated dictionary?

To reproduce, install both of these, and you can't switch between them in the context menu:
https://addons.mozilla.org/en-US/firefox/addon/us-english-dictionary/
https://addons.mozilla.org/en-US/firefox/addon/united-states-english-spellche/

I'm attempting to follow the directions here:  https://developer.mozilla.org/en-US/docs/Mozilla/Creating_a_spell_check_dictionary_add-on

Looks like a dictionary that is a slight modification of an en-US dictionary needs to still have the locale of en-US?

Comment 5

[Darxus]

Similarly, if I install two dictionaries with the locale of en-GB, I can't select between them.  Less of a problem because I'm able to remove all but one.

Maybe the context menu, under Languages, should list the em:name ("British English Dictionary (Marco Pinto)"), instead of "English (United States)" / "English (United Kingdom)"?

Reproducible by installing these two:
https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary/
https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary-2/

Comment 6

[Timea Cernea [:tbabos][inactive]]

Sorry for the waiting Darxus!

Reproduced on Latest Nightly 64.0a1 (2018-09-30) (64-bit) with the addons from Comment 5.

I will mark this issue as an enhancement for now and developers will decide if it can be treated as a bug or not. Indeed it is quite confusing which dictionary is selected or to choose between two with the same locale.

Thanks for the report.

Comment 7

[Darxus]

Thank you.

Comment 8

[Darxus]

Looks like I reported this September 13th, 2018. Just over a year ago. Can somebody tell me how an existing menu, that is not usable, because it doesn't display more than one dictionary of any language, is an "enhancement" and not a "defect"?

To be clear: The problem is, I can't select any US English spellchecker dictionary other than the default one. Because the menu won't show them.

Comment 9

[Markus Stange [:mstange]]

A non-functional menu item is definitely a bug and not an enhancement.

So does this only happen with dictionaries that have the exact same name as the built-in dictionary? Also, to make things easier, could you post some steps to reproduce that start with an empty Firefox profile?

Comment 10

[Timea Cernea [:tbabos][inactive]]

Looked into this once more, sorry for marking it as an enhancement back then, it is definitely a bug.

This doesn't seem to be a regression, mozregression went back to 2018-04-30 (in this builds the addons wouldn't install due to the corrupted error) and the next build from 2018-05-01 already has this bug.

It happens for dictionaries that have the same name. If I install a Lithuanian dictionary I can select it from the context menu.
One of the ones mentioned by the reporter in comment 5 don't even show up in the context menu.

STR:

1. Launch Firefox with a new profile
2. Install the following dictionaries:
   https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary/
   https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary-2/
3. Go to Pastebin.com
4. Right-click on the text input field -> Languages

Actual: Only English (United States)" / "English (United Kingdom)" appear in the context menu. The second United Kingdom (british english) dictionary does not appear in the context menu.

Updating affected flags and removing regression-window wanted keyword.

Comment 11

[Darxus]

Can anybody point me to where this stuff is handled in the source code?

(In reply to Markus Stange [:mstange] from comment #9)

So does this only happen with dictionaries that have the exact same name as the built-in dictionary? Also, to make things easier, could you post some steps to reproduce that start with an empty Firefox profile?

Was Timea Cernea's response adequate?

Comment 12

[Markus Stange [:mstange]]

Yes it was, thanks Timea!

Comment 13

[Darxus]

I'm still working on a custom spelling dictionary that I'd like to publish, that I can't even use, because this menu is broken, 20 months later. I'm still interested in pointers on where to poke around in the source.

Comment 14

[Darxus]

Yesterday was the two year anniversary of this bug. I still have a custom dictionary that I would like to publish, that I can't use because of this bug.

Comment 15

[Darxus]

Happy three year anniversary. I still can't use my custom spelling dictionary because of this bug.