changing spelling dictionary doesn't work

NEW
Unassigned

Status

()

--
enhancement
6 months ago
6 months ago

People

(Reporter: darxus-mozillabug, Unassigned)

Tracking

62 Branch
Points:
---

Firefox Tracking Flags

(firefox64 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
Posted image firefoxboth.png
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180905221508

Steps to reproduce:

Start with English language pack and dictionary.  Add German dictionary.  Disable English language pack and dictionaries.  Enable German dictionary.  Type English and German words.


Actual results:

Spellchecker said English word was correct, and German word was not.  Meaning changing spellchecker languages didn't work.


Expected results:

Spellchecker should've said English word was wrong, and German word was correct.
(Reporter)

Comment 1

6 months ago
I failed to mention that I did try restarting firefox, that didn't help.
(Reporter)

Comment 2

6 months ago
I also tried disabling all my extensions, and restarting.  No improvement.

Comment 3

6 months ago
Hi Darxus,

The default spell checker language is English, so the word will always be checked first using the default integrated English Dictionary. 
If you have other languages installed (in your case German) please make sure to enable the language pack and select it via the Context Menu option. It will correctly spell check all that you wrote before and was highlighted as incorrect.
Here is an example of how to do that: https://streamable.com/p8lq0

Please tell me if this solves the issue or if I missed something.

Thanks
Flags: needinfo?(darxus-mozillabug)
(Reporter)

Comment 4

6 months ago
I am now able to switch from English to German (I was not changing the language via the context menu).  

But I still can't do what I want to do.  Should I open a new bug?  Take this to the support-firefox@ list?

I've created (and installed) my own English (US) dictionary, based on the integrated one, with a few words removed.  It looks like I can't ever select my dictionary, because I can't disable the integrated English dictionary, and they are both en-US?  In the context menu, I only see the one "English (United States)" option.  

So it looks to me like there's a bug preventing me from switching to any other dictionary with the same locale (en-US) as the integrated dictionary?

To reproduce, install both of these, and you can't switch between them in the context menu:
https://addons.mozilla.org/en-US/firefox/addon/us-english-dictionary/
https://addons.mozilla.org/en-US/firefox/addon/united-states-english-spellche/

I'm attempting to follow the directions here:  https://developer.mozilla.org/en-US/docs/Mozilla/Creating_a_spell_check_dictionary_add-on

Looks like a dictionary that is a slight modification of an en-US dictionary needs to still have the locale of en-US?
(Reporter)

Comment 5

6 months ago
Similarly, if I install two dictionaries with the locale of en-GB, I can't select between them.  Less of a problem because I'm able to remove all but one.

Maybe the context menu, under Languages, should list the em:name ("British English Dictionary (Marco Pinto)"), instead of "English (United States)" / "English (United Kingdom)"?

Reproducible by installing these two:
https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary/
https://addons.mozilla.org/en-US/firefox/addon/british-english-dictionary-2/
Flags: needinfo?(darxus-mozillabug)
Component: Untriaged → Spelling checker
Product: Firefox → Core

Comment 6

6 months ago
Sorry for the waiting Darxus!

Reproduced on Latest Nightly 64.0a1 (2018-09-30) (64-bit) with the addons from Comment 5.

I will mark this issue as an enhancement for now and developers will decide if it can be treated as a bug or not. Indeed it is quite confusing which dictionary is selected or to choose between two with the same locale.

Thanks for the report.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
status-firefox64: --- → affected
Ever confirmed: true
(Reporter)

Comment 7

6 months ago
Thank you.
You need to log in before you can comment on or make changes to this bug.