Ensure iceccream works with the tup backend

RESOLVED FIXED in Firefox 64

Status

defect
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: cmanchester, Assigned: cmanchester)

Tracking

(Blocks 1 bug)

Trunk
mozilla64
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

From experimenting in the sf office I needed to export a couple of environment variables (at least ICECC_VERSION) to the compile processes in the tup backend to get everything working correctly. I'll confirm with someone who knows a bit more about the icecream setup but will post a prospective fix here.
Assignee: nobody → cmanchester
This fixes the icecream behavior for `j30` and lower on my setup!
(In reply to Chris Manchester (:chmanchester) from comment #1)
> Created attachment 9008542 [details]
> Bug 1490763 - Export ICECC environment variables to compilation commands in
> the tup backend.

This approach, while effective for this case, exposes the more general discrepancy between the make and Tup builds: while setting 'mk_add_options "export FOO=..."' in a mozconfig will set FOO in the environment of commands that run during the make build, we don't export all of these values in the Tup build. As an alternative to this patch we could, but because of Tup's approach to the environment it could end up invalidating a lot of the build unnecessarily when a mozconfig changes, because we don't know which commands depend on which environment variables.
Comment on attachment 9008542 [details]
Bug 1490763 - Export ICECC environment variables to compilation commands in the tup backend.

Michael Shal [:mshal] has approved the revision.
Attachment #9008542 - Flags: review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/391f1d4d5cda
Export ICECC environment variables to compilation commands in the tup backend. r=mshal
https://hg.mozilla.org/mozilla-central/rev/391f1d4d5cda
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.