1490763 - Ensure iceccream works with the tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

From experimenting in the sf office I needed to export a couple of environment variables (at least ICECC_VERSION) to the compile processes in the tup backend to get everything working correctly. I'll confirm with someone who knows a bit more about the icecream setup but will post a prospective fix here.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1490763 - Export ICECC environment variables to compilation commands in the tup backend.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

This fixes the icecream behavior for `j30` and lower on my setup!

Comment 3

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester (:chmanchester) from comment #1)
> Created attachment 9008542 [details]
> Bug 1490763 - Export ICECC environment variables to compilation commands in
> the tup backend.

This approach, while effective for this case, exposes the more general discrepancy between the make and Tup builds: while setting 'mk_add_options "export FOO=..."' in a mozconfig will set FOO in the environment of commands that run during the make build, we don't export all of these values in the Tup build. As an alternative to this patch we could, but because of Tup's approach to the environment it could end up invalidating a lot of the build unnecessarily when a mozconfig changes, because we don't know which commands depend on which environment variables.

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 9008542 [details]
Bug 1490763 - Export ICECC environment variables to compilation commands in the tup backend.

Michael Shal [:mshal] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/391f1d4d5cda
Export ICECC environment variables to compilation commands in the tup backend. r=mshal

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/391f1d4d5cda