Closed Bug 1490774 Opened 6 years ago Closed 6 years ago

Unable to land a patch series

Categories

(Conduit :: Lando, defect)

Product:
Conduit
Component:
Lando
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: mccr8, Unassigned)

Details

Bug 1457525 comment 6 says this should work, but it isn't working for me. I went to this revision, which is the 4th patch in a series: https://lando.services.mozilla.com/D5616/ https://phabricator.services.mozilla.com/D5616 says this depends on 5593, and so on up the chain, but only part 4 is shown. It sounds like it should show open ancestors? I also tried landing it and it hit a rebase error, as expected. I uploaded this patch using Phlay, so maybe there's some problem with the meta data.
It looks like phabricator didn't process the metadata in the commit message. In the list of actions in the right side-bar, there is "Edit related revision". You'll need to link them there.
As :tomprince indicated, these revisions aren't properly linked into a stack on Phabricator. It looks like "Depends on 5593" was put in the commit summary which is missing the "D". It should have been "Depends on D5593.". :mccr8, please link the revisions manually using the instructions in Comment 1.
No longer blocks: 1457525
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Ah, I wondered about that missing D. I'll look at what Phlay is doing and file an issue there (as I imagine that's what put the depends stuff in). Thanks.
Yeah I think I found the problem in Phlay, so I'll submit a pull request there after I've confirmed it works.
You need to log in before you can comment on or make changes to this bug.