1490858 - Streamline nsISHEntry

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[Nicholas Nethercote [inactive]]

Still more shistory clean-ups.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Make most nsISHEntry attributes infallible

The patch also removes some NS_ENSURE_ARG_POINTER checks from these attributes'
getters. Most of these getters already lack such checks, and as long as the
infallible getters are used a non-null pointer is guaranteed. In the worst case
we'll safely null-crash anyway.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Streamline nsISHEntry a little more

By marking some C++-only nsISHistory methods as [noscript] or [noscript,
notxpcom].

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Simplify some nsISHEntry attributes

Both nsISHEntry.URI and nsISHEntry isSubFrame are readonly, but also have a
setter. This is silly, so this patch removes the setter and makes them
modifiable.

The patch also renames nsISHEntry.setAsHistoryLoad() as setLoadTypeAsHistory(),
which makes it clearer that it modifies the loadType attribute.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Reorder nsISHEntry

nsISHEntry's attributes and methods are thoroughly mixed. This patch separates
them, making it easier to understand.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9008575 [details] [diff] [review]
Make most nsISHEntry attributes infallible

Review of attachment 9008575 [details] [diff] [review]:
-----------------------------------------------------------------

File a bug for supporting infallible on string class types and refer to it?

Comment 6

[Nicholas Nethercote [inactive]]

> File a bug for supporting infallible on string class types and refer to it?

Bug 1491187.

Comment 7

[Nicholas Nethercote [inactive]]

Attachment: Update comm-central for nsISHEntry changes

nsISHEntry.{URI,isSubFrame} both lost an explicit setter, but became mutable.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc1de79de88f
Make most nsISHEntry attributes infallible. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/abf70961a783
Streamline nsISHEntry a little more. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/505759d44fda
Simplify some nsISHEntry attributes. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a68b5804d5
Reorder nsISHEntry. r=nika

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cc1de79de88f
https://hg.mozilla.org/mozilla-central/rev/abf70961a783
https://hg.mozilla.org/mozilla-central/rev/505759d44fda
https://hg.mozilla.org/mozilla-central/rev/c6a68b5804d5

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9008989 [details] [diff] [review]
Update comm-central for nsISHEntry changes

Looks good. Big thanks.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4fa52926ba4c
Update comm-central for nsISHEntry changes. r=frg