Closed Bug 1490877 Opened Last year Closed Last year

Support final AV1 MP4 MIME type

Categories

(Firefox :: File Handling, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: strobe, Assigned: TD-Linux)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.92 Safari/537.36

Steps to reproduce:

The final AV1 codec string in the MP4 MIME type is not supported in Firefox. Instead the beta AV1 codec string is used.

MediaSource.isTypeSupported('video/mp4; codecs="av01.0.05M.08")
MediaSource.isTypeSupported('video/mp4; codecs="av1")



Actual results:

-> false
-> true


Expected results:

-> true
-> false
Indeed, it's actually supposed to accept both strings. Will take a look asap.
Assignee: nobody → tdaede
While the MP4 parser correctly handles the av01* codec string, it
is then converted to a video/av01* mimetype to search for a PDM.
The libaom PDM only accepts video/av1, so always produce a video/av1
MIME type from a codecs=av01 string.

Alternately, the AOMDecoder could be made to accept video/av01*, but
this patch matches what VPXDecoder does.
Comment on attachment 9008636 [details]
Bug 1490877: Make codecs=av01* mimetypes work with MSE. r=jya

Jean-Yves Avenard [:jya] has approved the revision.
Attachment #9008636 - Flags: review+
Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c48f0cea901
Make codecs=av01* mimetypes work with MSE. r=jya
Component: Untriaged → File Handling
Status: UNCONFIRMED → NEW
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/2c48f0cea901
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment on attachment 9008636 [details]
Bug 1490877: Make codecs=av01* mimetypes work with MSE. r=jya

Approval Request Comment
[Feature/Bug causing the regression]: 1452683
[User impact if declined]: Youtube will not detect AV1 support
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: it only affects a feature behind a pref
[String changes made/needed]: None
Attachment #9008636 - Flags: approval-mozilla-beta?
Comment on attachment 9008636 [details]
Bug 1490877: Make codecs=av01* mimetypes work with MSE. r=jya

Low-risk patch improving AV1 support,  uplift approved for 63 beta 7, thanks.
Attachment #9008636 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.