1490882 - The last test of test_middle_click_paste.html is always ignored

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

copyHTMLContent always fails to copy contents in <iframe>. It shows the <iframe> but does not wait its reflow so that it fails to retrieve Selection for the contentWindow. Then, SimpleTest.waitForClipboard() rejects but copyHTMLContent just call SimpleTest.finish(). Therefore, the failure hasn't been recorded.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1490882 - Fix a bug of test_middle_click_paste.html

When I added some tests into test_middle_click_paste.html, I realized that
SimpleTest.waitForClipboard() in copyHTMLContent() fails to copy the
HTML fragment to clipboard and just quit the test.  Therefore, only the
last tests are ignored always.

The reason is, iframe.contentDocument.getSelection() returns nullptr
since the frame becomes visible immediately before accessing the Selection.

This patch makes flushing the pending layout with scrollTop.  This makes
getSelection() return non-null.

However, unfortunately, only on Linux, it fails to copy the content.  I'm
still not sure the reason. This patch just avoids running the last part
only on Linux.

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 9008633 [details]
Bug 1490882 - Fix a bug of test_middle_click_paste.html

Makoto Kato [:m_kato] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70ae129e43a4
Fix a bug of test_middle_click_paste.html r=m_kato

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/70ae129e43a4