1490967 - Treeherder no longer works with uppercase mail address

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Masatoshi Kimura [:emk]]

This is a recent regression. I can't filter the result with my mail address anymore. This is very critical for me.

Comment 1

[Ed Morley [:emorley]]

Hi! Sorry that's broken - we'll get it fixed asap.

The prod push yesterday included:
https://github.com/mozilla/treeherder/compare/22042de6cedb...b5a6736f9b26

Of that, I think it might be from one of:
https://github.com/mozilla/treeherder/pull/3923
https://github.com/mozilla/treeherder/pull/3971

Comment 2

[Cameron Dawson [:camd]]

Looking into this now.

Comment 3

[Cameron Dawson [:camd]]

Sorry for the inconvenience.  I have a fix coming up in a couple minutes...

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4032

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 9009244 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4032

Many thanks :-)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d19f0a791c0c5ec974014740726002acc2fa5572
Bug 1490967 - Fix filtering with uppercase email address (#4032)

Comment 7

[Masatoshi Kimura [:emk]]

How did you confirm the fix? I can't get the result with this URL yet:
https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]

Comment 8

[Cameron Dawson [:camd]]

This hasn't been pushed to production yet.  But you can test it on stage, so this works:

https://treeherder.allizom.org/#/jobs?repo=try&author=[e-mail]

Please feel free to do any extra testing on there to ensure I got things working correctly, though.  :)

Comment 9

[Masatoshi Kimura [:emk]]

Thank you. But I could not login on the allizom.org domain:
> Request has been terminated Possible causes: the network is offline, Origin is not allowed by Access-Control-Allow-Origin, the page is being unloaded, etc.

So I'll have to wait until it is pushed to production.

Comment 10

[Ed Morley [:emorley]]

Treeherder bugs are marked fixed when the PR merges to master (most of the webapp projects on Bugzilla take this approach). Deployment to stage (https://treeherder.allizom.org) then occurs automatically within 15 minutes, and to production when a manual push is made to the `production` branch (normally around once a week).

The currently deployed revision can be found via:
* In-app help menu -> "What's deployed" link
* Repo README (https://github.com/mozilla/treeherder) -> "What's Deployed" badge
* Wiki page (https://wiki.mozilla.org/EngineeringProductivity/Projects/Treeherder) -> "Deployed changes info"

Repeating the STR on stage works for me, so closing this out again - but as Cameron said let us know if you find anything else :-)

(In reply to Masatoshi Kimura [:emk] from comment #9)
> Thank you. But I could not login on the allizom.org domain:
> > Request has been terminated Possible causes: the network is offline, Origin is not allowed by Access-Control-Allow-Origin, the page is being unloaded, etc.

That sounds like the symptoms that were being seen in bug 1490864. If you could add any additional info in that bug, it will help with tracking the issue down (I think it might be an issue with the auth0-js library).