Closed Bug 1490993 Opened Last year Closed Last year

Always use braces for if/for/while statements in platform-specific jit/ directories

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(6 files)

This is the last piece. I didn't convert these directories initially because I wanted to review the changes a bit more carefully (because comparing the shell binary doesn't find issues in code that isn't compiled for the current platform).
Comment on attachment 9008722 [details]
Bug 1490993 part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r?mgaudet

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.
Attachment #9008722 - Flags: review+
Comment on attachment 9008725 [details]
Bug 1490993 part 3 - Always use braces for if/for/while statements in js/src/jit/x86-shared. r?nbp

Nicolas B. Pierron [:nbp] has approved the revision.
Attachment #9008725 - Flags: review+
Comment on attachment 9008727 [details]
Bug 1490993 part 5 - Always use braces for if/for/while statements in js/src/jit/arm64. r?luke

Luke Wagner [:luke] has approved the revision.
Attachment #9008727 - Flags: review+
Comment on attachment 9008723 [details]
Bug 1490993 part 2 - Always use braces for if/for/while statements in js/src/jit/x86. r?tcampbell

Ted Campbell [:tcampbell] has approved the revision.
Attachment #9008723 - Flags: review+
Comment on attachment 9008726 [details]
Bug 1490993 part 4 - Always use braces for if/for/while statements in js/src/jit/arm. r?bbouvier

Ted Campbell [:tcampbell] has approved the revision.
Attachment #9008726 - Flags: review+
Comment on attachment 9008728 [details]
Bug 1490993 part 6 - Always use braces for if/for/while statements in js/src/jit/{mips32,mips64,mips-shared}. r?bbouvier

Ted Campbell [:tcampbell] has approved the revision.
Attachment #9008728 - Flags: review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7bbf9560f451
part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3c10148fb9a8
part 2 - Always use braces for if/for/while statements in js/src/jit/x86. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e6cce3b04ab6
part 3 - Always use braces for if/for/while statements in js/src/jit/x86-shared. r=nbp
https://hg.mozilla.org/integration/autoland/rev/63a03fced45b
part 4 - Always use braces for if/for/while statements in js/src/jit/arm. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/371ea5445585
part 5 - Always use braces for if/for/while statements in js/src/jit/arm64. r=luke
https://hg.mozilla.org/integration/autoland/rev/0667570cb938
part 6 - Always use braces for if/for/while statements in js/src/jit/{mips32,mips64,mips-shared}. r=tcampbell
You need to log in before you can comment on or make changes to this bug.