1490993 - Always use braces for if/for/while statements in platform-specific jit/ directories

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Jan de Mooij [:jandem]]

This is the last piece. I didn't convert these directories initially because I wanted to review the changes a bit more carefully (because comparing the shell binary doesn't find issues in code that isn't compiled for the current platform).

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1490993 part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r?mgaudet

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1490993 part 2 - Always use braces for if/for/while statements in js/src/jit/x86. r?tcampbell

Depends on D5762

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1490993 part 3 - Always use braces for if/for/while statements in js/src/jit/x86-shared. r?nbp

Depends on D5763

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Comment on attachment 9008722 [details]
Bug 1490993 part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r?mgaudet

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1490993 part 4 - Always use braces for if/for/while statements in js/src/jit/arm. r?bbouvier

Depends on D5764

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1490993 part 5 - Always use braces for if/for/while statements in js/src/jit/arm64. r?luke

Depends on D5765

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1490993 part 6 - Always use braces for if/for/while statements in js/src/jit/{mips32,mips64,mips-shared}. r?bbouvier

Depends on D5766

Comment 8

[Nicolas B. Pierron [:nbp]]

Comment on attachment 9008725 [details]
Bug 1490993 part 3 - Always use braces for if/for/while statements in js/src/jit/x86-shared. r?nbp

Nicolas B. Pierron [:nbp] has approved the revision.

Comment 9

[Luke Wagner [:luke]]

Comment on attachment 9008727 [details]
Bug 1490993 part 5 - Always use braces for if/for/while statements in js/src/jit/arm64. r?luke

Luke Wagner [:luke] has approved the revision.

Comment 10

[Ted Campbell [:tcampbell]]

Comment on attachment 9008723 [details]
Bug 1490993 part 2 - Always use braces for if/for/while statements in js/src/jit/x86. r?tcampbell

Ted Campbell [:tcampbell] has approved the revision.

Comment 11

[Ted Campbell [:tcampbell]]

Comment on attachment 9008726 [details]
Bug 1490993 part 4 - Always use braces for if/for/while statements in js/src/jit/arm. r?bbouvier

Ted Campbell [:tcampbell] has approved the revision.

Comment 12

[Ted Campbell [:tcampbell]]

Comment on attachment 9008728 [details]
Bug 1490993 part 6 - Always use braces for if/for/while statements in js/src/jit/{mips32,mips64,mips-shared}. r?bbouvier

Ted Campbell [:tcampbell] has approved the revision.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bbf9560f451
part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3c10148fb9a8
part 2 - Always use braces for if/for/while statements in js/src/jit/x86. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e6cce3b04ab6
part 3 - Always use braces for if/for/while statements in js/src/jit/x86-shared. r=nbp
https://hg.mozilla.org/integration/autoland/rev/63a03fced45b
part 4 - Always use braces for if/for/while statements in js/src/jit/arm. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/371ea5445585
part 5 - Always use braces for if/for/while statements in js/src/jit/arm64. r=luke
https://hg.mozilla.org/integration/autoland/rev/0667570cb938
part 6 - Always use braces for if/for/while statements in js/src/jit/{mips32,mips64,mips-shared}. r=tcampbell

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7bbf9560f451
https://hg.mozilla.org/mozilla-central/rev/3c10148fb9a8
https://hg.mozilla.org/mozilla-central/rev/e6cce3b04ab6
https://hg.mozilla.org/mozilla-central/rev/63a03fced45b
https://hg.mozilla.org/mozilla-central/rev/371ea5445585
https://hg.mozilla.org/mozilla-central/rev/0667570cb938