1490997 - Use nsAtom instead of nsString for font family name in the FontFamilyName struct

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Jonathan Kew [:jfkthame]]

Followup to bug 1490402 comment 4: it would probably make sense to switch the mName field here from nsString to nsAtom:

https://searchfox.org/mozilla-central/rev/a23c3959b62cd3f616435e02810988ef5bac9031/gfx/thebes/gfxFontFamilyList.h#164

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: WiP patch to convert FontFamilyName::mName from string to atom

Here's a prototype patch that I think makes most of the Gecko changes required; but it doesn't currently build because (naturally) it breaks Stylo compilation.

It's not immediately obvious to me how to handle the nsAtom field from the Rust side, so Emilio, any chance you could fix that up (to spare me hours of digging around)? :) Thanks!

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Style changes.

Sure, there you go :)

Comment 3

[Jonathan Kew [:jfkthame]]

Awesome, thanks! I've pushed a try job to see if anything breaks... https://treeherder.mozilla.org/#/jobs?repo=try&revision=042e736be74f69e88d664b948141659148edb312.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Use nsAtom instead of nsString for font family name in the FontFamilyName struct, and switch its methods from 16-bit to 8-bit strings

This is a followup to bug 1490402, removing 16-bit string usage from the FontFamilyName struct and related methods. (This incorporates Emilio's patch for the Rust side of things.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bae2e21a9312
Use nsAtom instead of nsString for font family name in the FontFamilyName struct, and switch its methods from 16-bit to 8-bit strings. r=lsalzman

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/bae2e21a9312