1491009 - Add a plain text view for json objects in the Params tab

Status: RESOLVED DUPLICATE of bug 1514750

(DevTools :: Netmonitor, defect, P3)

Description

[Colin]

Attachment: json_object_no_plain_text.PNG

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180830143136

Steps to reproduce:

Inspect any XHR POST request that has parameters
Open up the the developer console
Click on the Network tab
Click on your request and open the Params tab
See that the JSON object is listed in the Params tab
See that there is no plain text view of that JSON object (For copy/paste)


Actual results:

Could not see any plain text version of the parameters of the POST request


Expected results:

Like the other tab "Response" I can see a "Response payload" view that shows the plain text of the JSON object. 

This bug was logged for just that:
https://bugzilla.mozilla.org/show_bug.cgi?id=859138

However, there is nothing similar in the Params tab.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

I agree the default "Request payload" section displaying the raw POST data should be available as well.

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some instructions for anyone interested in fixing this:

1) The Params panel is implemented (as React component) here:
https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/devtools/client/netmonitor/src/components/ParamsPanel.js#44

2) The "Request payload" section is used here:
https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/devtools/client/netmonitor/src/components/ParamsPanel.js#139

But, it's only used if the post body is *not* JSON. It should be always there (perhaps collapsed by default)

3) We also need a test for it.
Existing tests might be used as a source of inspiration:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/browser_net_post-data-01.js

... and all the browser_net_post-data-* other tests

Honza

Comment 3

[Adjoa]

Hi Jan - I'm interested in fixing this bug.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you!

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Adjoa: Any progress on this issue? Do you need help?

Honza

Comment 6

[Adjoa]

Hey @Honza - Nothing to report yet.

Comment 7

[Hengyeow (:tanhengyeow)]

Hi Adjoa

Are you still working on this? Do you require any assistance? :)

Comment 8

[Hemakshi Sachdev [:hemakshis]]

Hi Colin & Jan,

I think this bug is the same as this one and it has been resolved now.
I think we should mark this one also as RESOLVED

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Agree, thanks for the note!
Honza