Closed
Bug 1491191
Opened 6 years ago
Closed 6 years ago
Remove unused methods in nsIEditorMailSupport
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
- insertAsCitedQuotation is used by test (editor/libeditor/tests/test_bug616590.xul). But I don't know we should keep this for test. - rewrap is unsed by comm-central. Although it used by cmd_rewrap, we might have to move this to c-c or move command implementation to gecko's editor code, such as cmd_removeLinks... Others are unused now.
|
Assignee | |
Comment 1•6 years ago
|
||
s/rewrap is unsed by comm-central/rewrap is used by comm-central/
|
|
Assignee | |
Comment 2•6 years ago
|
||
Since I have landed bug 1489939, comm-central only uses rewrap method in nsIEditorMailSupport. And insertAsCitedQuotation is used by the test of editor/libeditor/tests/test_bug616590.xul. Other methods are unused now, so let's remove these from nsIEditorMailSupprt, and move it to HTMLEditor. Also, pasteAsQuotation is unused now even if BlueGriffon.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9008993 [details] Bug 1491191 - Remove unused methods in nsIEditorMailSupport. r?masayuki Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9008993 -
Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/0b212a6e641a Remove unused methods in nsIEditorMailSupport. r=masayuki
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b212a6e641a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
||
Updated•4 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•