Closed Bug 1491203 Opened 2 years ago Closed 2 years ago

Web Payment IDL files have missing w3c copyright

Categories

(Core :: DOM: Web Payments, defect, P1, trivial)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → mcaceres
Severity: normal → trivial
Priority: -- → P1
Attached patch Adds copyright and comment (obsolete) — Splinter Review
Attachment #9009009 - Flags: review?(bzbarsky)
Comment on attachment 9009009 [details] [diff] [review]
Adds copyright and comment

>+ *   https://www.w3.org/TR/payment-request/#paymentmethodchangeevent-interface

Is it that, or https://w3c.github.io/payment-request/#dom-paymentmethodchangeevent ?

Also, if this IDL came from that spec, is the copyright really MPL?
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #2)
> Comment on attachment 9009009 [details] [diff] [review]
> Adds copyright and comment
> 
> >+ *   https://www.w3.org/TR/payment-request/#paymentmethodchangeevent-interface
> 
> Is it that, or
> https://w3c.github.io/payment-request/#dom-paymentmethodchangeevent ?

The former is ok. It gives a better overview.  

> Also, if this IDL came from that spec, is the copyright really MPL?

So, you are correct that it should probably be the W3C Doc/Software license. The other files are wrong also I think, because copy/pasta cargo cult. I'll see if I can find some correct license text.
Summary: PaymentMethodChangeEvent.webidl missing copyright and link to spec → Web Payment IDL files have missing w3c copyright
This matches the other IDL files. It's an improvement, but it's still not right as per the W3C Document and Software license:
 
https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document

We will need to do a big find/replace on all the WebIDL files to fix them, but as a separate bug.
Attachment #9009009 - Attachment is obsolete: true
Attachment #9009009 - Flags: review?(bzbarsky)
Attachment #9009017 - Flags: review?(bzbarsky)
Attachment #9009017 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/67f6883be55d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.