Closed
Bug 1491203
Opened 2 years ago
Closed 2 years ago
Web Payment IDL files have missing w3c copyright
Categories
(Core :: DOM: Web Payments, defect, P1)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: marcosc, Assigned: marcosc)
References
Details
Attachments
(1 file, 1 obsolete file)
4.03 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → mcaceres
Severity: normal → trivial
Priority: -- → P1
Assignee | ||
Comment 1•2 years ago
|
||
Attachment #9009009 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•2 years ago
|
||
Comment on attachment 9009009 [details] [diff] [review] Adds copyright and comment >+ * https://www.w3.org/TR/payment-request/#paymentmethodchangeevent-interface Is it that, or https://w3c.github.io/payment-request/#dom-paymentmethodchangeevent ? Also, if this IDL came from that spec, is the copyright really MPL?
Assignee | ||
Comment 3•2 years ago
|
||
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #2) > Comment on attachment 9009009 [details] [diff] [review] > Adds copyright and comment > > >+ * https://www.w3.org/TR/payment-request/#paymentmethodchangeevent-interface > > Is it that, or > https://w3c.github.io/payment-request/#dom-paymentmethodchangeevent ? The former is ok. It gives a better overview. > Also, if this IDL came from that spec, is the copyright really MPL? So, you are correct that it should probably be the W3C Doc/Software license. The other files are wrong also I think, because copy/pasta cargo cult. I'll see if I can find some correct license text.
Assignee | ||
Updated•2 years ago
|
Summary: PaymentMethodChangeEvent.webidl missing copyright and link to spec → Web Payment IDL files have missing w3c copyright
Assignee | ||
Comment 4•2 years ago
|
||
This matches the other IDL files. It's an improvement, but it's still not right as per the W3C Document and Software license: https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document We will need to do a big find/replace on all the WebIDL files to fix them, but as a separate bug.
Attachment #9009009 -
Attachment is obsolete: true
Attachment #9009009 -
Flags: review?(bzbarsky)
Attachment #9009017 -
Flags: review?(bzbarsky)
![]() |
||
Updated•2 years ago
|
Attachment #9009017 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•2 years ago
|
Keywords: checkin-needed
Comment 5•2 years ago
|
||
This landed here: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=67f6883be55ddf8601475b0b6278a54dd113753f https://hg.mozilla.org/integration/mozilla-inbound/rev/67f6883be55ddf8601475b0b6278a54dd113753f
Updated•2 years ago
|
Keywords: checkin-needed
Comment 6•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/67f6883be55d
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•