Closed Bug 1491212 Opened 2 years ago Closed 2 years ago

Make Document.exitFullscreen() return a promise

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(4 files)

There is some non-trivial work to implement this on top of having requestFullscreen() return Promise, so I decide to spawn it into a separate bug from bug 1188256.
Assignee: nobody → xidorn+moz
The next patch would create another subclass of FullscreenChange for
handling fullscreen exit.

Depends on D5988
Priority: -- → P2
Comment on attachment 9009506 [details]
Bug 1491212 part 1 - Move PendingFullscreenRequestList to a higher place. r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9009506 - Flags: review+
Comment on attachment 9009509 [details]
Bug 1491212 part 4 - Fix a wpt of exitFullscreen to check against the right Promise. r=smaug

Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9009509 - Flags: review+
Comment on attachment 9009508 [details]
Bug 1491212 part 3 - Have Document.exitFullscreen return a Promise. r=smaug

Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9009508 - Flags: review+
Comment on attachment 9009507 [details]
Bug 1491212 part 2 - Have a new FullscreenChange superclass split from FullscreenRequest. r=smaug

Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) has approved the revision.
Attachment #9009507 - Flags: review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12e1e7b2f4a7
part 1 - Move PendingFullscreenRequestList to a higher place. r=smaug
https://hg.mozilla.org/integration/autoland/rev/824f566f9043
part 2 - Have a new FullscreenChange superclass split from FullscreenRequest. r=smaug
https://hg.mozilla.org/integration/autoland/rev/32b021561f8c
part 3 - Have Document.exitFullscreen return a Promise. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b444a3e482d8
part 4 - Fix a wpt of exitFullscreen to check against the right Promise. r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13041 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Keywords: dev-doc-needed
Updated documentation as part of the big push on Fullscreen docs, and listed this change on Firefox 64 for developers.

https://developer.mozilla.org/en-US/docs/Web/API/Document/exitFullscreen
You need to log in before you can comment on or make changes to this bug.