Closed Bug 1491253 Opened 6 years ago Closed 6 years ago

Link UrlbarInput, UrlbarView and UrlbarController together

Categories

(Firefox :: Address Bar, enhancement, P1)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1491253 - Link the UrlbarController with the input and the view.
46 bytes, text/x-phabricator-request
dao
: review+
Details | Review
As the next part of the work for the controller, we should hook it into the input and the view, so that we have a partial results flow. The model side will still be missing, but that can be added later, and we'll just simulate results for now.
Blocks: 1492481
Note: view visibility is bug 1492481, so for now, I've just made the visibility parts "work".
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place. Also hooks up the input with determining if we're in private browsing mode or not.
Comment on attachment 9010272 [details] Bug 1491253 - Link the UrlbarController with the input and the view. Dão Gottwald [::dao] has approved the revision.
Attachment #9010272 - Flags: review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/261d22d6d396 Link the UrlbarController with the input and the view. r=dao
Backed out changeset 261d22d6d396 (bug 1491253) for browser-chrome failures at browser/base/content/test/static/browser_all_files_referenced.js Backout: https://hg.mozilla.org/integration/autoland/rev/3dfc23d7f7c0d8b6475fd92636e36207ed07200a Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=261d22d6d396d542f1745d6bcf2222188948c6ac Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=200425917&repo=autoland&lineNumber=2719 task 2018-09-20T11:06:37.165Z] 11:06:37 INFO - TEST-PASS | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - [task 2018-09-20T11:06:37.165Z] 11:06:37 INFO - Buffered messages finished [task 2018-09-20T11:06:37.166Z] 11:06:37 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unused whitelist entry: resource://app/modules/UrlbarController.jsm - [task 2018-09-20T11:06:37.167Z] 11:06:37 INFO - Stack trace: [task 2018-09-20T11:06:37.167Z] 11:06:37 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:784 [task 2018-09-20T11:06:37.168Z] 11:06:37 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102 [task 2018-09-20T11:06:37.169Z] 11:06:37 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093 [task 2018-09-20T11:06:37.169Z] 11:06:37 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995 [task 2018-09-20T11:06:37.170Z] 11:06:37 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 [task 2018-09-20T11:06:37.172Z] 11:06:37 INFO - ignored unused whitelist entry: resource://app/blocklist.xml [task 2018-09-20T11:06:37.172Z] 11:06:37 INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json [task 2018-09-20T11:06:37.174Z] 11:06:37 INFO - ignored unused whitelist entry: resource://gre/res/test.properties [task 2018-09-20T11:06:37.175Z] 11:06:37 INFO - missing file: resource://gre/modules/commonjs/toolkit/loader.js [task 2018-09-20T11:06:37.176Z] 11:06:37 INFO - missing file: chrome://help/content/help.js referenced from chrome://pippki/content/protectedAuth.xul [task 2018-09-20T11:06:37.179Z] 11:06:37 INFO - missing file: resource://gre/modules/GeckoViewTelemetryController.jsm referenced from resource://gre/components/ContentProcessSingleton.js [task 2018-09-20T11:06:37.180Z] 11:06:37 INFO - missing file: resource://services-sync/)%20==%200)%20%7B referenced from resource://services-sync/addonutils.js [task 2018-09-20T11:06:37.182Z] 11:06:37 INFO - missing file: resource://gre/modules/worker/myModule.js referenced from resource://gre/modules/workers/require.js [task 2018-09-20T11:06:37.183Z] 11:06:37 INFO - missing file: resource://gre/modules/workers/SimpleTest.js referenced from resource://gre/modules/workers/require.js [task 2018-09-20T11:06:37.184Z] 11:06:37 INFO - missing file: resource://gre/modules/workers/Logger.js referenced from resource://gre/modules/workers/require.js [task 2018-09-20T11:06:37.185Z] 11:06:37 INFO - missing file: resource://gre/modules/MulticastDNSAndroid.jsm referenced from resource://gre/components/nsDNSServiceDiscovery.js [task 2018-09-20T11:06:37.186Z] 11:06:37 INFO - missing file: resource://gre/modules/WindowsRegistry.jsm referenced from resource://gre/components/nsUpdateService.js,resource://gre/modules/NativeManifests.jsm,resource://gre/modules/UpdateUtils.jsm,resource://gre/modules/TelemetryEnvironment.jsm,resource://app/components/nsBrowserGlue.js,resource://app/modules/MigrationUtils.jsm,resource://app/modules/ShellService.jsm [task 2018-09-20T11:06:37.186Z] 11:06:37 INFO - missing file: resource://gre/modules/glenn.htm referenced from resource://gre/modules/microformat-shiv.js [task 2018-09-20T11:06:37.187Z] 11:06:37 INFO - missing file: resource://gre/modules/jane.html referenced from resource://gre/modules/microformat-shiv.js [task 2018-09-20T11:06:37.187Z] 11:06:37 INFO - missing file: resource://gre/modules/jane.jpeg referenced from resource://gre/modules/microformat-shiv.js [task 2018-09-20T11:06:37.188Z] 11:06:37 INFO - missing file: resource://gre/modules/glenn.html referenced from resource://gre/modules/microformat-shiv.js [task 2018-09-20T11:06:37.188Z] 11:06:37 INFO - missing file: resource://gre/modules/Snackbars.jsm referenced from chrome://global/content/aboutSupport.js [task 2018-09-20T11:06:37.189Z] 11:06:37 INFO - missing file: chrome://gfxsanity/content/sanityparent.html referenced from resource://gre/components/marionette.js [task 2018-09-20T11:06:37.190Z] 11:06:37 INFO - missing file: resource://gre/modules/Messaging.jsm referenced from chrome://global/content/aboutTelemetry.js,resource://gre/modules/ReaderMode.jsm,resource://gre/modules/PushRecord.jsm,resource://gre/modules/accessibility/AccessFu.jsm [task 2018-09-20T11:06:37.191Z] 11:06:37 INFO - missing file: resource://gre/modules/*.svg referenced from resource://gre/modules/PageThumbUtils.jsm [task 2018-09-20T11:06:37.191Z] 11:06:37 INFO - missing file: resource://gre/modules/OSCrypto_win.js referenced from resource://gre/modules/OSCrypto.jsm [task 2018-09-20T11:06:37.192Z] 11:06:37 INFO - missing file: resource://gre/modules/osfile/osfile_win_allthreads.jsm referenced from resource://gre/modules/osfile/osfile_async_front.jsm,resource://gre/modules/osfile/osfile_native.jsm [task 2018-09-20T11:06:37.193Z] 11:06:37 INFO - missing file: chrome://browser/content/extension-mac.css referenced from resource://gre/modules/ExtensionParent.jsm [task 2018-09-20T11:06:37.194Z] 11:06:37 INFO - missing file: resource://gre/modules/subprocess/subprocess_win.jsm referenced from resource://gre/modules/Subprocess.jsm [task 2018-09-20T11:06:37.194Z] 11:06:37 INFO - missing file: resource://gre/modules/osfile/osfile_win_back.jsm referenced from resource://gre/modules/osfile.jsm [task 2018-09-20T11:06:37.195Z] 11:06:37 INFO - missing file: resource://gre/modules/osfile/osfile_win_front.jsm referenced from resource://gre/modules/osfile.jsm [task 2018-09-20T11:06:37.196Z] 11:06:37 INFO - missing file: resource://gre/modules/RuntimePermissions.jsm referenced from resource://gre/modules/DownloadIntegration.jsm [task 2018-09-20T11:06:37.197Z] 11:06:37 INFO - missing file: resource://android/ referenced from resource://gre/modules/UserAgentUpdates.jsm [task 2018-09-20T11:06:37.198Z] 11:06:37 INFO - missing file: resource://gre/modules/PushServiceAndroidGCM.jsm referenced from resource://gre/modules/PushService.jsm [task 2018-09-20T11:06:37.199Z] 11:06:37 INFO - missing file: chrome://global/content/manifestMessages.js referenced from resource://gre/modules/ManifestObtainer.jsm [task 2018-09-20T11:06:37.199Z] 11:06:37 INFO - missing file: chrome://extensions/content/schemas/manifest/version referenced from chrome://extensions/content/schemas/management.json [task 2018-09-20T11:06:37.200Z] 11:06:37 INFO - missing file: chrome://extensions/content/schemas/manifest/version#version_name referenced from chrome://extensions/content/schemas/management.json [task 2018-09-20T11:06:37.201Z] 11:06:37 INFO - missing file: chrome://extensions/content/schemas/manifest/icons referenced from chrome://extensions/content/schemas/management.json [task 2018-09-20T11:06:37.202Z] 11:06:37 INFO - missing file: chrome://extensions/content/schemas/events#filtered referenced from chrome://extensions/content/schemas/events.json [task 2018-09-20T11:06:37.203Z] 11:06:37 INFO - missing file: chrome://extensions/content/schemas/extension.html#property-lastError referenced from chrome://extensions/content/schemas/downloads.json [task 2018-09-20T11:06:37.204Z] 11:06:37 INFO - missing file: chrome://global/skin/plugins.css referenced from chrome://global/content/plugins.html [task 2018-09-20T11:06:37.215Z] 11:06:37 INFO - missing file: chrome://global/content/crashreporter/aboutcrashes.ftl referenced from chrome://global/content/crashes.xhtml [task 2018-09-20T11:06:37.217Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/applicationManager.ftl referenced from chrome://browser/content/preferences/applicationManager.xul [task 2018-09-20T11:06:37.219Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/siteDataSettings.css referenced from chrome://browser/content/preferences/siteDataRemoveSelected.xul,chrome://browser/content/preferences/siteDataSettings.xul [task 2018-09-20T11:06:37.220Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/siteDataSettings.ftl referenced from chrome://browser/content/preferences/siteDataRemoveSelected.xul,chrome://browser/content/preferences/siteDataSettings.xul [task 2018-09-20T11:06:37.221Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/branding/sync-brand.ftl referenced from chrome://browser/content/preferences/in-content/syncDisconnect.xul,chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.223Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/syncDisconnect.ftl referenced from chrome://browser/content/preferences/in-content/syncDisconnect.xul [task 2018-09-20T11:06:37.224Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/fonts.ftl referenced from chrome://browser/content/preferences/fonts.xul [task 2018-09-20T11:06:37.225Z] 11:06:37 INFO - missing file: chrome://payments/content/true referenced from chrome://payments/content/paymentDialogWrapper.xul [task 2018-09-20T11:06:37.226Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/permissions.ftl referenced from chrome://browser/content/preferences/sitePermissions.xul,chrome://browser/content/preferences/permissions.xul [task 2018-09-20T11:06:37.226Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/connection.ftl referenced from chrome://browser/content/preferences/connection.xul [task 2018-09-20T11:06:37.228Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/preferences.ftl referenced from chrome://browser/content/preferences/connection.xul [task 2018-09-20T11:06:37.230Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/branding/brand.ftl referenced from chrome://browser/content/preferences/connection.xul,chrome://browser/content/preferences/siteDataSettings.xul,chrome://browser/content/preferences/clearSiteData.xul,chrome://browser/content/preferences/blocklists.xul,chrome://browser/content/preferences/browserLanguages.xul [task 2018-09-20T11:06:37.231Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/languages.ftl referenced from chrome://browser/content/preferences/languages.xul,chrome://browser/content/preferences/browserLanguages.xul [task 2018-09-20T11:06:37.232Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/clearSiteData.ftl referenced from chrome://browser/content/preferences/clearSiteData.xul [task 2018-09-20T11:06:37.242Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/containers.ftl referenced from chrome://browser/content/preferences/containers.xul [task 2018-09-20T11:06:37.243Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/colors.ftl referenced from chrome://browser/content/preferences/colors.xul [task 2018-09-20T11:06:37.244Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/blocklists.ftl referenced from chrome://browser/content/preferences/blocklists.xul [task 2018-09-20T11:06:37.245Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/branding/brand.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.252Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/preferences.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.253Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/fonts.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.254Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/blocklists.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.254Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/clearSiteData.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.255Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/colors.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.256Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/connection.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.256Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/languages.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.257Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/permissions.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.257Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/selectBookmark.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.258Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/in-content/browser/preferences/siteDataSettings.ftl referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.259Z] 11:06:37 INFO - missing file: chrome://browser/locale/preferences.properties referenced from chrome://browser/content/preferences/in-content/preferences.xul [task 2018-09-20T11:06:37.260Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/translation.ftl referenced from chrome://browser/content/preferences/translation.xul [task 2018-09-20T11:06:37.260Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/browser/preferences/selectBookmark.ftl referenced from chrome://browser/content/preferences/selectBookmark.xul [task 2018-09-20T11:06:37.262Z] 11:06:37 INFO - missing file: resource://gre/modules/SimpleServiceDiscovery.jsm referenced from chrome://browser/content/browser.js [task 2018-09-20T11:06:37.263Z] 11:06:37 INFO - missing file: resource:///modules/WindowsPreviewPerTab.jsm referenced from chrome://browser/content/browser.js [task 2018-09-20T11:06:37.263Z] 11:06:37 INFO - missing file: resource:///modules/Windows8WindowFrameColor.jsm referenced from chrome://browser/content/browser.js [task 2018-09-20T11:06:37.265Z] 11:06:37 INFO - missing file: resource://gre/modules/commonjs/ referenced from chrome://devtools/content/debugger/utils.js [task 2018-09-20T11:06:37.266Z] 11:06:37 INFO - missing file: chrome://browser/content/hiddenWindow.xul referenced from resource://app/defaults/preferences/firefox.js [task 2018-09-20T11:06:37.272Z] 11:06:37 INFO - missing file: resource://gre/localization/%7Blocale%7D/ referenced from resource://app/components/nsBrowserGlue.js [task 2018-09-20T11:06:37.274Z] 11:06:37 INFO - missing file: resource://app/localization/%7Blocale%7D/ referenced from resource://app/components/nsBrowserGlue.js [task 2018-09-20T11:06:37.275Z] 11:06:37 INFO - missing file: resource:///modules/AsanReporter.jsm referenced from resource://app/components/nsBrowserGlue.js [task 2018-09-20T11:06:37.276Z] 11:06:37 INFO - missing file: resource:///modules/WindowsJumpLists.jsm referenced from resource://app/components/nsBrowserGlue.js [task 2018-09-20T11:06:37.278Z] 11:06:37 INFO - missing file: chrome://branding/content/icon referenced from resource://app/components/nsBrowserGlue.js [task 2018-09-20T11:06:37.279Z] 11:06:37 INFO - missing file: chrome://browser/content/pref/pref.xul referenced from resource://app/components/nsBrowserContentHandler.js [task 2018-09-20T11:06:37.280Z] 11:06:37 INFO - missing file: chrome://browser/content/preferences/preferences.xul referenced from resource://app/components/nsBrowserContentHandler.js [task 2018-09-20T11:06:37.281Z] 11:06:37 INFO - missing file: chrome://browser/skin/preferences/application.png referenced from chrome://browser/content/preferences/in-content/main.js [task 2018-09-20T11:06:37.283Z] 11:06:37 INFO - missing file: resource://test/ referenced from resource://devtools/shared/worker/loader.js,resource://devtools/shared/Loader.jsm [task 2018-09-20T11:06:37.284Z] 11:06:37 INFO - missing file: resource://app/some/link.html referenced from resource://devtools-client-shared/node-attribute-parser.js [task 2018-09-20T11:06:37.285Z] 11:06:37 INFO - missing file: resource://testing-common/content-task.js%20line%2059%20%3E%20eval referenced from resource://devtools/client/webconsole/test/fixtures/stubs/pageError.js [task 2018-09-20T11:06:37.287Z] 11:06:37 INFO - missing file: resource:///modules/policies/WindowsGPOParser.jsm referenced from resource://app/components/EnterprisePolicies.js [task 2018-09-20T11:06:37.288Z] 11:06:37 INFO - missing file: resource://gre/actors/ActorChild.jsm referenced from resource://app/actors/PageMetadataChild.jsm [task 2018-09-20T11:06:37.289Z] 11:06:37 INFO - missing file: resource:///modules/ContextMenuChild.jsm referenced from resource://app/actors/PageMetadataChild.jsm [task 2018-09-20T11:06:37.290Z] 11:06:37 INFO - missing file: chrome://browser/content/extension-mac-panel.css referenced from resource://app/modules/ExtensionPopups.jsm [task 2018-09-20T11:06:37.292Z] 11:06:37 INFO - missing file: chrome://browser/content/extension-win-panel.css referenced from resource://app/modules/ExtensionPopups.jsm [task 2018-09-20T11:06:37.293Z] 11:06:37 INFO - missing file: chrome://browser/content/policies/branding/brand.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml [task 2018-09-20T11:06:37.294Z] 11:06:37 INFO - missing file: chrome://browser/content/policies/browser/branding/sync-brand.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml [task 2018-09-20T11:06:37.295Z] 11:06:37 INFO - missing file: chrome://browser/content/policies/browser/aboutPolicies.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml [task 2018-09-20T11:06:37.297Z] 11:06:37 INFO - missing file: chrome://browser/content/policies/browser/policies/policies-descriptions.ftl referenced from chrome://browser/content/policies/aboutPolicies.xhtml [task 2018-09-20T11:06:37.298Z] 11:06:37 INFO - missing file: resource://screenshots-addon/ referenced from jar:file:///builds/worker/workspace/build/application/firefox/browser/features/screenshots@mozilla.org.xpi!/webextension/background/senderror.js [task 2018-09-20T11:06:37.381Z] 11:06:37 INFO - Leaving test bound checkAllTheFiles [task 2018-09-20T11:06:37.431Z] 11:06:37 INFO - Console message: No chrome package registered for chrome://help/content/help.js [task 2018-09-20T11:06:37.433Z] 11:06:37 INFO - Console message: No chrome package registered for chrome://gfxsanity/content/sanityparent.html [task 2018-09-20T11:06:37.457Z] 11:06:37 INFO - GECKO(1934) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration. [task 2018-09-20T11:06:37.459Z] 11:06:37 INFO - GECKO(1934) | MEMORY STAT | vsize 988MB | residentFast 694MB | heapAllocated 460MB
Flags: needinfo?(standard8)
Bah, I'd remembered about that test, but forgotten to update it :-(
Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/861fdf8eabf2 Link the UrlbarController with the input and the view. r=dao
https://hg.mozilla.org/mozilla-central/rev/861fdf8eabf2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: