1491289 - Nightly: build fails when compiling third_party/prio: fatal error: nss/blapit.h: No such file or directory

Status: RESOLVED FIXED

(Toolkit :: General, defect, P5)

Description

[Robert-André Mauchin]

3:40.71 In file included from /builddir/build/BUILD/gecko-dev-a548d10a8c6e1e5d762714832715a880d9d290d8/third_party/prio/prio/client.c:9:
 3:40.72 /builddir/build/BUILD/gecko-dev-a548d10a8c6e1e5d762714832715a880d9d290d8/third_party/prio/include/mprio.h:17:10: fatal error: nss/blapit.h: No such file or directory
 3:40.72  #include <nss/blapit.h>
 3:40.72           ^~~~~~~~~~~~~~
 3:40.72 compilation terminated.
 3:40.72 gmake[4]: *** [/builddir/build/BUILD/gecko-dev-a548d10a8c6e1e5d762714832715a880d9d290d8/config/rules.mk:779: client.o] Error 1


I'm using using system-wide nss and nspr. See build log here: https://copr-be.cloud.fedoraproject.org/results/eclipseo/firefox-nightly/fedora-rawhide-x86_64/00798109-firefox-nightly/build.log.gz

Comment 1

[Mike Hommey [:glandium]]

NSS headers should not be included with nss/ paths, but "directly".

Comment 2

[Robert Helmer [:rhelmer]]

Going to fix this upstream then re-vendor into m-c: https://github.com/mozilla/libprio/pull/40

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: Bug 1491289 - re-vendor libprio to pick up fixes for using system NSS r?glandium

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9009771 [details]
Bug 1491289 - re-vendor libprio to pick up fixes for using system NSS r?glandium

Mike Hommey [:glandium] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/131a80cf6661
re-vendor libprio to pick up fixes for using system NSS r=glandium

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/131a80cf6661