Closed Bug 1491321 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 13007 - [css-properties-values-api] Detect font-relative units via var() refs.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13007 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13007 Details from upstream follow. Anders Hartvoll Ruud <andruud@chromium.org> wrote: > [css-properties-values-api] Detect font-relative units via var() refs. > > The has[_root]_font_unit flags were accidentally ignored in one of > CSSVariableData's constructors, and also not propagated properly during > variable resolution. This caused us to lose any knowledge about these units > if they appeared via an inner var() reference. > > Also: > > * Fix incorrect rem test which tested the wrong thing due to the > 'compute_dimension' utility mutating its style. > * Reduce the chance of such errors in the future by cleaning the state > between every test, and also at the end of 'compute_dimension'. > > R=chrishtr@chromium.org > > Bug: 641877 > Change-Id: If67cf4453e886f4c9430826c7cbe358e380c3f64 > Reviewed-on: https://chromium-review.googlesource.com/1226492 > WPT-Export-Revision: 36fb829f63c2ca8f2b45fbe64fa8441eb1bcfb21
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 1 subtests OK : 1 FAIL : 1
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bbf68d2707a7 [wpt PR 13007] - [css-properties-values-api] Detect font-relative units via var() refs., a=testonly
https://hg.mozilla.org/mozilla-central/rev/bbf68d2707a7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.