Closed
Bug 1491383
Opened 6 years ago
Closed 6 years ago
let the user select a row with the mouse in about:performance
Categories
(Toolkit :: Performance Monitoring, enhancement)
Toolkit
Performance Monitoring
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
|
6.12 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
This will be needed for the next UI steps where we will have a row of buttons at the top of the list to let users take actions on a page.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9009190 -
Flags: review?(felipc)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9009190 [details] [diff] [review] Patch Review of attachment 9009190 [details] [diff] [review]: ----------------------------------------------------------------- Why store selectedId if you could just do .selectedRow.windowId?
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9009190 [details] [diff] [review] Patch Review of attachment 9009190 [details] [diff] [review]: ----------------------------------------------------------------- Talked on IRC, r+ with getting rid of the selectedId property and using the selected row to access it
Attachment #9009190 -
Flags: review?(felipc) → review+
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/d21d5800c839 let the user select a row with the mouse in about:performance, r=felipe.
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d21d5800c839
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•