let the user select a row with the mouse in about:performance

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

This will be needed for the next UI steps where we will have a row of buttons at the top of the list to let users take actions on a page.
Posted patch PatchSplinter Review
Attachment #9009190 - Flags: review?(felipc)
Comment on attachment 9009190 [details] [diff] [review]
Patch

Review of attachment 9009190 [details] [diff] [review]:
-----------------------------------------------------------------

Why store selectedId if you could just do .selectedRow.windowId?
Comment on attachment 9009190 [details] [diff] [review]
Patch

Review of attachment 9009190 [details] [diff] [review]:
-----------------------------------------------------------------

Talked on IRC, r+ with getting rid of the selectedId property and using the selected row to access it
Attachment #9009190 - Flags: review?(felipc) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d21d5800c839
let the user select a row with the mouse in about:performance, r=felipe.
https://hg.mozilla.org/mozilla-central/rev/d21d5800c839
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.