1491395 - Update webrender to 6fa046c936b9d720726d27c3b0514ee66a305b69

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Darkspirit]

+++ This bug was initially created as a clone of Bug #1491130 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e36790648004550a9a04b8742d963ed31add5d53

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/153d6dc38962
Update webrender to commit 6fa046c936b9d720726d27c3b0514ee66a305b69
https://hg.mozilla.org/integration/mozilla-inbound/rev/432d22af68c8
Replace BorderWidths with LayoutSideOffsets.

Comment 3

[Andreea Pavel [:apavel]]

Backed out for failing awsy\test_memory_usage.py 

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&selectedJob=199991961&revision=432d22af68c825eebd86482c714b3cffcba408c7

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199991961&repo=mozilla-inbound&lineNumber=2286

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/911c7836b359cfa31f82e8f90e411e4c9709ade7

Comment 4

[Bobby Holley (:bholley)]

The test is failing because heap-unclassified is negative. Usually that means bogus memory reporting. WebRender memory reports shouldn't be running at all on non-WR jobs like the failing one, but if they were, but it is somewhat suspicious given that we recently added reporters for WR.

Unfortunately, the assertion seems to prevent uploading of the memory reports as artifacts. I've done a try push with the assertion disabled, so that we can hopefully access the reports:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fc210a6a72b5938c11d7f0a6382e1a7720f3cf7

Comment 5

[Andreea Pavel [:apavel]]

Also, clipboard failures appeared after:


https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&fromchange=b11de2700b907740938641f3525022d7f247d2ec&selectedJob=200009435


https://treeherder.mozilla.org/logviewer.html#?job_id=200009435&repo=mozilla-inbound&lineNumber=4889

18:59:52     INFO - TEST-OK | toolkit/components/aboutmemory/tests/test_aboutmemory5.xul | took 2107ms
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 872, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 872, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 3884, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 3884, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 452, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 452, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 872, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: f[ile z:/build/bPuild/src/xpcoarent m/threa3ds/nsThread.cpp, line 866956, Gecko_
18:59:52     INFO - GECKO(3956) | IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 452, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file z:/build/build/src/xpcom/threads/nsThread.cpp, line 866
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Child 3884, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file z:/build/build/src/xpcom/threads/nsThread.cpp, line 866
18:59:52     INFO - GECKO(3956) | [Parent 3956, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
18:59:52     INFO - GECKO(3956) | [Parent 3956, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005: file z:/build/build/src/docshell/shistory/nsSHistory.cpp, line 1291
18:59:52     INFO - GECKO(3956) | [Parent 3956, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005: file z:/build/build/src/docshell/shistory/nsSHistory.cpp, line 1291
18:59:52     INFO - GECKO(3956) | ++DOMWINDOW == 63 (12798400) [pid = 3956] [serial = 63] [outer = 18178120]
18:59:52     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/aboutmemory/tests/test_aboutmemory5.xul | assertion count 6 is more than expected 0 assertions
18:59:52     INFO - GECKO(3956) | [Child 452, Main Thread] WARNING: '!gThread', file z:/build/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
18:59:52     INFO - GECKO(3956) | [Child 872, Main Thread] WARNING: '!gThread', file z:/build/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
18:59:52     INFO - TEST-START | Shutdown
18:59:52     INFO - Passed:  24
18:59:52     INFO - Failed:  0
18:59:52     INFO - Todo:    0
18:59:52     INFO - Mode:    non-e10s
18:59:52     INFO - Slowest: 2218ms - chrome://mochitests/content/chrome/toolkit/components/aboutmemory/tests/test_aboutmemory.xul
18:59:52     INFO - SimpleTest FINISHED
18:59:52     INFO - TEST-INFO | Ran 1 Loops
18:59:52     INFO - SimpleTest FINISHED

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Here's an update with the changes before the BorderWidths changes: https://hg.mozilla.org/try/rev/4a2612717909c77523dd110e637839615decc4b9

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6854e1f0473e
Update webrender to commit 6fa046c936b9d720726d27c3b0514ee66a305b69
https://hg.mozilla.org/integration/mozilla-inbound/rev/32f29c236dde
Replace BorderWidths with LayoutSideOffsets. on a CLOSED TREE

Comment 8

[Andreea Pavel [:apavel]]

Relanded this since it was not the culprit for the above mentioned issue. 

I apologize for the confusion, the real culprit was Bug 1491395.

Comment 9

[Bobby Holley (:bholley)]

(In reply to Andreea Pavel [:apavel] from comment #8)
> Relanded this since it was not the culprit for the above mentioned issue. 
> 
> I apologize for the confusion, the real culprit was Bug 1491395.

I think you mean bug 1491037.

Thanks for tracking it down and relanding!

Comment 10

[Andreea Pavel [:apavel]]

Yes, wrong paste. Bug 1491037.

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6854e1f0473e
https://hg.mozilla.org/mozilla-central/rev/32f29c236dde