Closed Bug 1491590 Opened 1 year ago Closed 1 year ago
Clip not set properly for ns
Display Mask items
46 bytes, text/x-phabricator-request
|Details | Review|
We currently set the clip to the paint rect in mask items. However since we don't do the ComputeVisibility with blob invalidation the paint rect is still set to the building rect and the clip doesn't end up getting set to the tighter bounds.
Making P1 because this is pretty big performance problem with SVG.
Priority: P2 → P1
The regular "fallback item" path in WebRenderCommandsBuilder sets the PaintRect to the clipped bounds of the item: https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/gfx/layers/wr/WebRenderCommandBuilder.cpp#1778-1790 Would that help here? Otherwise we may just want to call ComputeVisibility the way FrameLayerBuilder does.
I'm confused, the linked code also calls ComputeVisibility?
You're right. For some reason I missed that.
This prevents us from doing unnecessary drawing because we clip to the bounds of the item.
Comment on attachment 9010753 [details] Bug 1491590. Make sure that the paint rect is set to the bounds Markus Stange [:mstange] has approved the revision.
Attachment #9010753 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4ed588ff40 Make sure that the paint rect is set to the bounds. r=mstange
You need to log in before you can comment on or make changes to this bug.