1491590 - Clip not set properly for nsDisplayMask items

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

We currently set the clip to the paint rect in mask items. However since we don't do the ComputeVisibility with blob invalidation the paint rect is still set to the building rect and the clip doesn't end up getting set to the tighter bounds.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Making P1 because this is pretty big performance problem with SVG.

Comment 2

[Markus Stange [:mstange]]

The regular "fallback item" path in WebRenderCommandsBuilder sets the PaintRect to the clipped bounds of the item: https://searchfox.org/mozilla-central/rev/bdc89dfd7869e418d788b28eb60ab8d94e708a15/gfx/layers/wr/WebRenderCommandBuilder.cpp#1778-1790

Would that help here? Otherwise we may just want to call ComputeVisibility the way FrameLayerBuilder does.

Comment 3

[Aria Beingessner [:Gankra]]

I'm confused, the linked code also calls ComputeVisibility?

Comment 4

[Markus Stange [:mstange]]

You're right. For some reason I missed that.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1491590. Make sure that the paint rect is set to the bounds

This prevents us from doing unnecessary drawing because we clip to
the bounds of the item.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58ee5b30a2edc61ebe4a92717aabba0bd4623fb5

Comment 7

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c439a3590637db8d4f635cb9fcb582c12515c85d

Comment 8

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b33b73d0e86e618cdefc3ba9ce875fa33525f51

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 9010753 [details]
Bug 1491590. Make sure that the paint rect is set to the bounds

Markus Stange [:mstange] has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4ed588ff40
Make sure that the paint rect is set to the bounds. r=mstange

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8d4ed588ff40