Closed
Bug 1491620
Opened 6 years ago
Closed 6 years ago
Split apply_declarations.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
I had a prototype of revert working, and all the code I had to copy around and all the reasoning I had to do about the random font stuff in the middle of apply_declarations drove me mad. So here's a bit cleaned up.
|
Assignee | |
Comment 1•6 years ago
|
||
All that font code thrown out in the middle was making me mad. There should be no change in behavior from this patch. I ran rustfmt on the code but I corrected manually the following: https://github.com/rust-lang-nursery/rustfmt/issues/3025
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93693818ad3530f06979b2393b1b7e8a957d60a6
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9009418 [details]
Split apply_declarations into its own file, and without mako.
Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009418 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/3e53a9519242 Split apply_declarations into its own file, and without mako. r=xidorn
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e53a9519242
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•