1491620 - Split apply_declarations.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

I had a prototype of revert working, and all the code I had to copy around and all the reasoning I had to do about the random font stuff in the middle of apply_declarations drove me mad. So here's a bit cleaned up.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Split apply_declarations into its own file, and without mako.

All that font code thrown out in the middle was making me mad.

There should be no change in behavior from this patch.

I ran rustfmt on the code but I corrected manually the following:

  https://github.com/rust-lang-nursery/rustfmt/issues/3025

Comment 2

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93693818ad3530f06979b2393b1b7e8a957d60a6

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 9009418 [details]
Split apply_declarations into its own file, and without mako.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e53a9519242
Split apply_declarations into its own file, and without mako. r=xidorn

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3e53a9519242