Status

()

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(6 attachments)

No description provided.
I always see a bunch of time in our profiles in the iterator over the
declarations, this ensures it's not something dumb.

I suspect it's just a bunch of cache misses from walking the rule tree but in
any case this is consistent with the other getters we have and such.
We never construct it.
There's no good reason we construct a DeclaredValue as an intermediate step.
I think it used to be the case that all PropertyDeclaration variants had a
DeclaredValueOwned<T> inside. But that's no longer the case, so this abstraction
seems less useful now.
Comment on attachment 9009420 [details]
Simplify CSSWideKeyword::parse.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009420 - Flags: review+
Comment on attachment 9009464 [details]
Make ExtremumLength::valid_for static.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009464 - Flags: review+
Comment on attachment 9009465 [details]
Remove DeclaredValue::WithVariables.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009465 - Flags: review+
Comment on attachment 9009467 [details]
Deindent the non-css-wide-keyword-related code from cascade_property.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009467 - Flags: review+
Comment on attachment 9009468 [details]
Remove DeclaredValue.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009468 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/fa669132189e
Make ExtremumLength::valid_for static. r=xidorn
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/a3b4475c493e
Remove DeclaredValue::WithVariables. r=xidorn
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/c626531e3717
Deindent the non-css-wide-keyword-related code from cascade_property. r=xidorn
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/162eb1cf7ad8
Simplify CSSWideKeyword::parse. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/fa669132189e
https://hg.mozilla.org/mozilla-central/rev/a3b4475c493e
https://hg.mozilla.org/mozilla-central/rev/c626531e3717
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment on attachment 9009419 [details]
Make LonghandId::flags an indexing operation.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9009419 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/3ba37496274a
Make LonghandId::flags an indexing operation. r=xidorn
You need to log in before you can comment on or make changes to this bug.