1491622 - Some minor cleanups.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Make LonghandId::flags an indexing operation.

I always see a bunch of time in our profiles in the iterator over the
declarations, this ensures it's not something dumb.

I suspect it's just a bunch of cache misses from walking the rule tree but in
any case this is consistent with the other getters we have and such.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Simplify CSSWideKeyword::parse.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Make ExtremumLength::valid_for static.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Remove DeclaredValue::WithVariables.

We never construct it.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Deindent the non-css-wide-keyword-related code from cascade_property.

There's no good reason we construct a DeclaredValue as an intermediate step.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Remove DeclaredValue.

I think it used to be the case that all PropertyDeclaration variants had a
DeclaredValueOwned<T> inside. But that's no longer the case, so this abstraction
seems less useful now.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9009420 [details]
Simplify CSSWideKeyword::parse.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9009464 [details]
Make ExtremumLength::valid_for static.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9009465 [details]
Remove DeclaredValue::WithVariables.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 10

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9009467 [details]
Deindent the non-css-wide-keyword-related code from cascade_property.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 11

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9009468 [details]
Remove DeclaredValue.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa669132189e
Make ExtremumLength::valid_for static. r=xidorn

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3b4475c493e
Remove DeclaredValue::WithVariables. r=xidorn

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c626531e3717
Deindent the non-css-wide-keyword-related code from cascade_property. r=xidorn

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/630122991233
Remove DeclaredValue. r=xidorn

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/162eb1cf7ad8
Simplify CSSWideKeyword::parse. r=xidorn

Comment 17

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fa669132189e
https://hg.mozilla.org/mozilla-central/rev/a3b4475c493e
https://hg.mozilla.org/mozilla-central/rev/c626531e3717

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/630122991233
https://hg.mozilla.org/mozilla-central/rev/162eb1cf7ad8

Comment 19

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9009419 [details]
Make LonghandId::flags an indexing operation.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba37496274a
Make LonghandId::flags an indexing operation. r=xidorn

Comment 21

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/3ba37496274a