Closed Bug 1491642 Opened 6 years ago Closed 6 years ago

add nodejs and cbindgen to tooltool manifest or releng packages

Categories

(SeaMonkey :: Build Config, enhancement)

Product:
SeaMonkey
Component:
Build Config
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

proposed patch (v2)
17.89 KB, patch
frg
: review+
Details | Diff | Splinter Review 
nodejs is needed to build now.  Will need the nodejs
tooltool package or releng package.
Summary: add nodejs to tooltool manifest or releng packages → add nodejs and cbindgen to tooltool manifest or releng packages
Attached patch proposed patch (obsolete) — — Splinter Review 
Assignee: nobody → ewong
Status: NEW → ASSIGNED

        Attachment #9013205 -
        Flags: review?(frgrahl)

    
    

    
  
Comment on attachment 9013205 [details] [diff] [review]
proposed patch

Looks good. I assume rust and gtk3 are picked up dieffrently now because you removed them.

For Windows and another bug: Builds switched to clang per default. I think we should just follow. The VS2017 package has been updated to 15.8 and now includes toolkit 10.1.17134.

        Attachment #9013205 -
        Flags: review?(frgrahl) → review+

    
    

    
  
(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> Comment on attachment 9013205 [details] [diff] [review]
> proposed patch
> 
> Looks good. I assume rust and gtk3 are picked up dieffrently now because you
> removed them.
> 
> For Windows and another bug: Builds switched to clang per default. I think
> we should just follow. The VS2017 package has been updated to 15.8 and now
> includes toolkit 10.1.17134.

Good catch.  No, wasn't intending rust and gtk3 to be removed.

    
    

    
  


  

        Attachment #9013205 -
        Attachment is obsolete: true

        Attachment #9013509 -
        Flags: review?(frgrahl)

        Attachment #9013509 -
        Flags: review?(frgrahl) → review+

    
    

    
  
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/a98e917dba66
Add nodejs and cbindgen to tooltoolmanifests. r=frg
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: