smtp AUTH PLAIN incomplete utf8 Password

RESOLVED FIXED in Thunderbird 64.0

Status

defect
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: yseckin, Assigned: infofrommozilla)

Tracking

Thunderbird 64.0

Thunderbird Tracking Flags

(thunderbird_esr6062+ fixed, thunderbird63 fixed, thunderbird64 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Posted file TB60smtp_auth_plain_bug.tar (obsolete) —
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180912143528

Steps to reproduce:

tried to authenticte with the password "1ä2a%00" the last "0" of the password will not transmit.
TLS/STARTTLS not active. The Fallback to AUTH LOGIN works. See the Wireshark sniff.


Actual results:

AUTH PLAIN will not work.


Expected results:

positive authentication
Attachment #9009538 - Attachment is obsolete: true
Component: Untriaged → Security
Perhaps related: bug 1474314.
Component: Security → Networking: SMTP
Product: Thunderbird → MailNews Core
When calculating the string length, the wrong string is used.
Attachment #9011285 - Flags: review?(jorgk)
Comment on attachment 9011285 [details] [diff] [review]
Fix 'truncated password' when using AUTH PLAIN (SMTP)

Thank you, Alfred!

I am very frustrated by this. Support for unicode passwords was in introduced in bug 312593 which landed exactly to the day *one* year ago. That code was reviewed by three people and no one saw the mistake:
https://hg.mozilla.org/comm-central/rev/23725f858c42#l17.61

The new unicode capability, which in fact never worked as we see here (and in bug 1493542), was advertised in the TB 57 release notes (https://www.thunderbird.net/en-US/thunderbird/57.0beta/releasenotes/). I couldn't test it since none of my mail providers accept non-ASCII passwords, so I hoped one of the complainers in bug 312593 would have tried it :-(

Then the code was touched again recently, and again, the mistake went unnoticed:
https://hg.mozilla.org/comm-central/rev/1519c2b5f8c4#l1.86
https://hg.mozilla.org/comm-central/rev/092c52d61cba#l1.17
Attachment #9011285 - Flags: review?(jorgk) → review+
Assignee: nobody → infofrommozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 9011285 [details] [diff] [review]
Fix 'truncated password' when using AUTH PLAIN (SMTP)

Since we advertise working UTF-8 passwords in TB 60, they'd better be working.
Attachment #9011285 - Flags: approval-comm-esr60+
Attachment #9011285 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/afd14a54871a
Fix 'truncated password' when using AUTH PLAIN (SMTP). r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.