"Add" button isn't grayed out when adding a wrong card number

VERIFIED FIXED in Firefox 64

Status

()

defect
P1
normal
VERIFIED FIXED
7 months ago
6 months ago

People

(Reporter: hani.yacoub, Assigned: jaws)

Tracking

64 Branch
Firefox 64
Points:
---

Firefox Tracking Flags

(firefox64 verified)

Details

(Whiteboard: [webpayments])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 months ago
Affected versions]: 
Nightly 64.0a1 

[Affected platforms]:
Platforms: Windows 10/7 x64, Ubuntu 18.04, Mac OS 10.13

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Make sure you have at least one Shipping Address and one Credit Card saved in your browser.

[Steps to reproduce]:
1. Go to "https://rsolomakhin.github.io/pr/single/" page and click on "Buy".
2. From "Payments Method" click on "Add".
3. Fill all the fields with correct data but leave "Card Number" empty for now.
4. Enter a valid Card number and observe "Add" button.
5. Add a any number to the card number.
6. Click anywhere and observe "Add" button.


[Expected result]:
"Add" button should be grayed out.

[Actual result]:
- Red outline is displayed all around the field.
- "Add" button isn't grayed out.
(Reporter)

Updated

7 months ago
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [webpayments] [triage]
(Reporter)

Comment 1

7 months ago
Posted image Add credit card.png
Priority: -- → P2
Whiteboard: [webpayments] [triage] → [webpayments]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
Attachment #9010065 - Attachment is obsolete: true
The validity of the cc-number field is only updated to a failure state after the 'change' event in the EditCreditCard class, but there was no code within basic-card-form.js to update the Save button enabled state after the 'change' event had been handled by EditCreditCard.
Comment on attachment 9010339 [details]
Bug 1491791 - Update the Save button state after the 'change' event. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9010339 - Flags: review+

Comment 5

7 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33a833eab418
Update the Save button state after the 'change' event. r=MattN

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33a833eab418
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
(Reporter)

Comment 7

7 months ago
Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 18.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.