1491809 - Make UndefinedBehaviorSanitizer be output as log level ERROR not INFO

Status: RESOLVED WORKSFORME

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Recently, UBSan was enabled for some builds in TH, but as the log below shows, the UndefinedBehaviorSanitizer failure (the actual problem from that run) was obscured by the later lines highlighted by the log.
https://treeherder.mozilla.org/logviewer.html#?job_id=199446694&repo=mozilla-inbound

Can we please ensure that UndefinedBehaviorSanitizer is a term we highlight on in the logs? Thanks!

Comment 1

[Ed Morley [:emorley]]

Hi!

We're no longer accepting regex changes in Treeherder for cases where the test harness/runner should be using appropriate log line prefixes, so in this case mozharness will need changing to make:

[task 2018-09-15T03:29:06.195Z] 03:29:06     INFO - PID 5962 | SUMMARY: UndefinedBehaviorSanitizer: ...

...be output as:

[task 2018-09-15T03:29:06.195Z] 03:29:06    ERROR - PID 5962 | SUMMARY: UndefinedBehaviorSanitizer: ...

That happens via this file:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/errors.py

Comment 2

[Ryan VanderMeulen [:RyanVM]]

pdknsk, is that something you'd be interested in doing? It would make it easier for us to see these UBSan failures when they occur in CI.

Comment 3

[u473386]

Appears simple enough for me to do.

Comment 4

[u473386]

It's probably not that simple. I don't know what to do with SanitizerErrorList.

--- a/testing/mozharness/mozharness/base/errors.py
+++ b/testing/mozharness/mozharness/base/errors.py
@@ -198,6 +198,10 @@ ZipalignErrorList = BaseErrorList + [{
     'level': ERROR,
 }]
 
+SanitizerErrorList = [{
+    'substr': r'''UndefinedBehaviorSanitizer:''',
+    'level': Error,
+}]
 
 # __main__ {{{1
 if __name__ == '__main__':

Comment 5

[Ryan VanderMeulen [:RyanVM]]

UBSan failures are definitely fatal these days.