Closed Bug 1491954 Opened 2 years ago Closed 2 years ago

Filping boolean half way for path() interpolation

Categories

(Core :: CSS Transitions and Animations, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

According to the discussion in https://github.com/w3c/svgwg/issues/543:

RESOLUTION: Flipping boolean and integers half way for path interpolation

It seems Chris will add interpolation for the path() function in SVG2 and the current wpt follows this rule.

Therefore, we could implement Animate for flags [1] in the path interpolation. And leave the update for SVG d attribute interpolation in Bug 653928.

[1] https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/servo/components/style/values/specified/svg_path.rs#201-204
We should be consistent. What do you want to do Jonathan?
Flags: needinfo?(jwatt)
(In reply to Robert Longson [:longsonr] from comment #1)
> We should be consistent. What do you want to do Jonathan?

Agree. :)
Assignee: nobody → boris.chiou
According to the new svg 2 spec update (#543), we flip the flag half way for
path interpolation.
Comment on attachment 9010052 [details]
Bug 1491954 - Flip boolean half way for path interpolation

Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #9010052 - Flags: review+
I'd like to push this first. If we want to be consistent on SVG d attribute, I can update it ASAP.
Pushed by boris.chiou@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fa6ae63a781a
Flip boolean half way for path interpolation r=emilio
https://hg.mozilla.org/mozilla-central/rev/fa6ae63a781a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
I don't have a strong opinion on this other than consistency between browsers. It seems a bit of an edge case.
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.