1491998 - Make browser_ext_chrome_settings_overrides_home.js wait for the right load to avoid race conditions

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[:Gijs (he/him)]

The test does:


  let windowOpenedPromise = BrowserTestUtils.waitForNewWindow();
  let win = OpenBrowserWindow();
  await windowOpenedPromise;
  await BrowserTestUtils.browserLoaded(win.gBrowser.selectedBrowser);
  let doc = win.document;


This is meant to wait for the extension homepage to load. However, it's possible for the page to have loaded by the time that we create the browserLoaded promise, because loading happens async when the window is created. This becomes likely enough with my changes in bug 1362774 (which avoid wasting time when creating the window by first trying to load about:blank in it) that the test intermittently fails.

Instead, the test can just tell `BTU.waitForNewWindow` to wait for the extension homepage load that it's expecting directly, making it more reliable and removing the need for the separate loading check.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1491998 - Fix browser_ext_chrome_settings_overrides_home.js to wait for the correct load, r?aswan

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 9009781 [details]
Bug 1491998 - Fix browser_ext_chrome_settings_overrides_home.js to wait for the correct load, r?aswan

Andrew Swan [:aswan] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b06f42d2b540
Fix browser_ext_chrome_settings_overrides_home.js to wait for the correct load, r=aswan

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b06f42d2b540

Comment 5

[Vlad Jiman]

Hello, will manual testing be required here? if so please provide some info onto how it should be tested, otherwise please set the qe-verify- flag. Thanks!

Comment 6

[:Gijs (he/him)]

This was a change to an automated test, so no manual verification is required.