Closed Bug 1492021 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13043 - [service-workers] Refactor tautological tests

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13043 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13043
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:
>  [service-workers] Refactor tautological tests
>  
>  Previously, these tests created Promise values which would be fulfilled
>  even when expectations were violated. This would cause the test harness
>  to interpret them as "passing" regardless of implementation status.
>  
>  Remove the use of `Promise.prototype.catch` to ensure that promise
>  rejections which occur during test execution lead to test failure.
Ran 1 tests and 5 subtests
OK     : 1
PASS   : 5
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/802d18a614e2
[wpt PR 13043] - [service-workers] Refactor tautological tests, a=testonly
https://hg.mozilla.org/mozilla-central/rev/802d18a614e2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.