1492065 - Unconditionally uses SSE2 instructions on x86

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Mike Hommey [:glandium]]

While Mozilla.org builds of Firefox dropped support for x86 CPUs without SSE2, downstreams may support it. This is generally handled gracefully by having runtime detection, and many things do it in Gecko. One that doesn't, though, is the Swizzle code.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1492065 - Use Swizzle fallback when SSE2 is not supported

The same is done for NEON, and the check folds to nothing when building
when the build target supports SSE2 and runtime detection is not
necessary.

Comment 2

[Lee Salzman [:lsalzman]]

Comment on attachment 9009873 [details]
Bug 1492065 - Use Swizzle fallback when SSE2 is not supported

Lee Salzman [:lsalzman] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/210b9e777cec
Use Swizzle fallback when SSE2 is not supported r=lsalzman

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9009873 [details]
Bug 1492065 - Use Swizzle fallback when SSE2 is not supported

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Necessary for some downstreams.
User impact if declined: Downstreams such as Debian provide OSes that work on older x86 machines, and as such, try to keep Firefox working on those machines. For users with such machines (and there are surprisingly lots of them), Firefox crashes without this patch.
Fix Landed on Version: 64
Risk to taking this patch (and alternatives if risky): For Firefox builds that Mozilla ships, the patch actually is a no-op: the added conditions turn into "if (true)". For downstreams like Debian, this just ensures SSE2 instructions are not used on machines without SSE2.
String or UUID changes made by this patch: N/A

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/210b9e777cec

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9009873 [details]
Bug 1492065 - Use Swizzle fallback when SSE2 is not supported

Fix for some downstream distros. Approved for ESR 60.3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/ec4b5969c6ae