1492114 - Third-party cookies description is unnecessarily wrapped

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of Third-Party cookies

All other descriptions used the available space, while blockCookiesCBDeck has a max-width of 444px

https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/browser/themes/shared/incontentprefs/privacy.css#135

Comment 1

[(no longer active)]

Attachment: Bug 1492114 - Ensure that the Third-Party Cookies description doesn't wrap unnecessarily

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 9009974 [details]
Bug 1492114 - Ensure that the Third-Party Cookies description doesn't wrap unnecessarily

Johann Hofmann [:johannh] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd174216895b
Ensure that the Third-Party Cookies description doesn't wrap unnecessarily r=johannh

Comment 4

[(no longer active)]

flod, I'd appreciate if you could verify the fix when this merges into Nightly.  Thanks!

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fd174216895b

Comment 6

[Francesco Lodolo [:flod]]

I'm using a build (64.0a1 (2018-09-21) (64 bit)) based on
https://hg.mozilla.org/mozilla-central/rev/eddbfdc38cbc

Which includes your landing (I see the CSS too in DevTools), but the issue is still there.

Comment 7

[(no longer active)]

Of course, sorry!  I got the selectors wrong.  :-(

Comment 8

[(no longer active)]

Attachment: Bug 1492114 - Really ensure that the Third-Party Cookies description doesn't wrap unnecessarily

The selector should apply to deck elements that do have a selectedIndex
attribute but it's not 0.

Comment 9

[Francesco Lodolo [:flod]]

Note that you can test this with pseudolocale, it's long enough to wrap
https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.html#pseudolocalization

Comment 10

[Johann Hofmann [:johannh]]

Comment on attachment 9011179 [details]
Bug 1492114 - Really ensure that the Third-Party Cookies description doesn't wrap unnecessarily

Johann Hofmann [:johannh] has approved the revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c366e594aeb
Really ensure that the Third-Party Cookies description doesn't wrap unnecessarily r=johannh

Comment 12

[(no longer active)]

(In reply to Francesco Lodolo [:flod] from comment #9)
> Note that you can test this with pseudolocale, it's long enough to wrap
> https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.
> html#pseudolocalization

Very nice, I wasn't aware of this!  I tested this patch by editing the string in devtools.  :-)

Comment 13

[(no longer active)]

Comment on attachment 9009974 [details]
Bug 1492114 - Ensure that the Third-Party Cookies description doesn't wrap unnecessarily

Approval Request Comment
[Feature/Bug causing the regression]: New feature
[User impact if declined]: comment 0
[Is this code covered by automated tests?]: Tested locally
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Both patches need to be uplifted
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple theme change
[String changes made/needed]: none

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9009974 [details]
Bug 1492114 - Ensure that the Third-Party Cookies description doesn't wrap unnecessarily

Simple CSS fix for l10n builds verified on nightly by flod, uplift approved for 63 beta 9 thanks.

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1c366e594aeb

Comment 16

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/946cccc1bb45

Comment 17

[Francesco Lodolo [:flod]]

Also verified on 64.0a1 (2018-09-24) (64 bit)

Comment 18

[Cristian Fogel [:cfogel]]

Managed to reproduce the issue on 63.0b8.
Verified with 64.0a1 (2018-09-25) and 63.0b9 on Win10x64, macOS10.13, Ubuntu 16.04 with the same lang-builds as reported one and can confirm as well that the issue is no longer encountered.

Comment 19

[(no longer active)]

FWIW part 2 landed on beta as https://hg.mozilla.org/releases/mozilla-beta/rev/ad1ff0504c04941457c9480760585399dfa80d4f.