1492129 - Diners Club (Carte Blanche) 14 digits and Visa (13 digits) are not validated as correct by the Luhn Algorithm

Status: RESOLVED DUPLICATE of bug 1485105

(Firefox :: WebPayments UI, defect)

Description

[Timea Cernea [:tbabos][inactive]]

[Affected versions]: 
Nightly 64.0a1 

[Affected platforms]:
Platforms: Windows 7/10 x64, Ubuntu 18.04, Mac OS 10.13

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Make sure you have at least one Shipping Address Card saved

[Steps to reproduce]:
1. Go to "https://rsolomakhin.github.io/pr/single/" page and click on "Buy" button.
2. Add a new Credit Card
3. Fill in the Card Number field with Diners Club specific 14 digits number, such as: 30112698929640
4. Fill in the Card Number field with Visa 13 digits number: 4222222222222	


[Expected result]:
The card numbers should pass the Luhn Algorithm. 

[Actual result]:
Then field is marked as invalid in both cases [3] [4]

[Notes]:
Diners club have 3 specific card number formats. As for the Carte Blanche which is 14 digits, the number will not be validated. https://www.getnewidentity.com/diners-club-credit-card.php

The Visa special 13 digits number was also mentioned to be correct and functional https://sfoster.github.io/payments-scratch/pans.html

Comment 1

[Sam Foster [:sfoster] (he/him)]

Our validation currently includes a length check before we attempt to validate against the Luhn algorithm. We currently enforce a tight range of number lengths which does not match reality and this is what is causing those numbers to be marked as invalid. This should be fixed by bug 1485105.