1492196 - Fix focus-related race conditions in browser_searchbar_openpopup.js

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[:Gijs (out until Jan 5th; he/him)]

In the drop_opens_popup.js, we attempt to simulate a drag from "somewhere else" to the search bar, and test whether the drop causes the popup to appear.

Unfortunately, the drag manager code ( https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/dom/events/EventStateManager.cpp#1837-1846 ) bails out of generating a drag (from the mousedown + mousemove events that EventUtils.js generates) if there's a selection frame that it thinks might be handling dragging. Because the previous test focuses the URL bar, sometimes that happens here and breaks the test, especially after flipping the uriIsAboutBlank switch in bug 1362774.

Comment 1

[Brian Grinstead [:bgrins]]

This test is the last orange I'm seeing with <searchbar> converted to a CE. I don't think this race is the reason, but going to keep an eye on this anyway.

Comment 2

[:Gijs (out until Jan 5th; he/him)]

Attachment: Bug 1492196 - fix browser_searchbar_openpopup.js so we don't accidentally try to drag content in the URL bar, r?florian

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 9010008 [details]
Bug 1492196 - fix browser_searchbar_openpopup.js so we don't accidentally try to drag content in the URL bar, r?florian

Florian Quèze [:florian] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bda9ea2048f2
fix browser_searchbar_openpopup.js so we don't accidentally try to drag content in the URL bar, r=florian

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bda9ea2048f2