1492216 - Land Onboarding Strings

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Comment 1

[Ursula Sarracini (:ursula)]

This bug will handle landing only the .ftl file for the onboarding message. One thing to note is that the .ftl file will not only include the UI strings (button labels, titles, etc), but for now, it will also include the messages themselves that need to be translated. This may change once we are able to use Fluent strings in the content process, or once we find another solution, but for now this is the best solution for us. 
The reason for landing the strings separately from the associated code to use them, is to avoid a messy backport into our github repo.
:flod, does that sound ok? We can wait until the associated code on github is r+'ed before landing the strings themselves, to try and land them together as much as possible.

Comment 2

[Francesco Lodolo [:flod]]

I think one file with both UI and messages is OK. We have section comments, and we can distinguish them somehow.

How much of the existing UI and messages is going to be reused? Asking, because we have scripts to import from .properties to .ftl, and we should plan for it if there's a lot to recover
https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_migrations.html

Comment 3

[Ursula Sarracini (:ursula)]

None of the UI and messages from the existing onboarding code will be re-used. All of the strings that are landing in the .ftl file are new, and belong to the simplified onboarding experience. Currently you can see the new strings we plan on landing here: https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/browser/components/newtab/lib/OnboardingMessageProvider.jsm
Once this new onboarding experience is translated and ready to be turned on for everyone, we're going to remove all the existing onboarding code that belongs to the legacy extension, including the .properties file.
Is that what you mean?

Comment 4

[Ursula Sarracini (:ursula)]

Attachment: Bug 1492216 - Land Onboarding Strings

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Ursula Sarracini (:ursula) from comment #3)
> None of the UI and messages from the existing onboarding code will be
> re-used. All of the strings that are landing in the .ftl file are new, and
> belong to the simplified onboarding experience. Currently you can see the
> new strings we plan on landing here:
> https://searchfox.org/mozilla-central/rev/
> 94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/browser/components/newtab/lib/
> OnboardingMessageProvider.jsm
> Once this new onboarding experience is translated and ready to be turned on
> for everyone, we're going to remove all the existing onboarding code that
> belongs to the legacy extension, including the .properties file.
> Is that what you mean?

Yes, thanks.

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 9010642 [details]
Bug 1492216 - Land Onboarding Strings

Francesco Lodolo [:flod] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a37fb677b59
Land Onboarding Strings r=flod

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9a37fb677b59

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/95f8e6265f24