1492225 - Check Stack Cookies (/GS) and if necessary re-enable on Windows clang-cl builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

When we switch to clang-cl we may have lost stack cookies; because the -GS option may not be provided to clang-cl by default

Comment 1

[Nathan Froyd [:froydnj]]

Note that we have seen -GS- give performance wins:

https://bugs.llvm.org/show_bug.cgi?id=38679

so something must be enabling -GS...?

Comment 2

[(Away)]

It's on by default. http://llvm-cs.pcc.me.uk/tools/clang/lib/Driver/ToolChains/Clang.cpp#5249

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Thanks!

Comment 4

[(Away)]

(In fact, the crux of 38679 is that LLVM's -GS is even _more_ on than MSVC's, for better or worse.)