Fix exception in browser.xhtml when opening findbar "Error: Attempt to inject localization link before document.head is available"

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Our helper function insertFTLIfNeeded assumes that document.head will be present in HTML docs. In browser.xhtml that's not the case, so we can either add a head tag there or make the function detect HTML documents in a different way.
(Assignee)

Comment 1

7 months ago
This prevents an exception in browser.xhtml when there's no head, since
it's currently sharing the markup with browser.xul.
Attachment #9010055 - Attachment description: Bug 1492247 - Allow for null document.head when inserting localization links;r=zbraniecki → Bug 1492247 - Allow for null document.head in browser.xhtml inserting localization links;r=zbraniecki
Comment on attachment 9010055 [details]
Bug 1492247 - Allow for null document.head in browser.xhtml inserting localization links;r=zbraniecki

Zibi Braniecki [:gandalf][:zibi] has approved the revision.
Attachment #9010055 - Flags: review+

Comment 3

7 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3857cbe7b717
Allow for null document.head in browser.xhtml inserting localization links;r=zbraniecki
(Assignee)

Updated

7 months ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3857cbe7b717
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
(Assignee)

Updated

7 months ago
See Also: → 1492582
You need to log in before you can comment on or make changes to this bug.