Closed Bug 1492305 Opened Last year Closed 5 months ago
Store promises does not reject after hitting cancel on master passsword prompt
STR: apply the patch and run the test on Linux and Mac. Expected: Mac: It will trigger OS keychain login twice or trice. You should hit cancel on the last one when the console prints "!!!!!!!!! Hit cancel here when prompted for password". The test should pass. Linux: The test should pass on its own since gMockPrompter.promptPassword() will return false? Actual: On Linux, we will reach |ok(false, "Should reject");| and result in a test failure. Note: Over bug 1486954 I am relying on this method to reject to tell if the user had canceled the login dialog. It does not seem to be the case on Linux; the method still resolves even though I hit cancel. Can we fix this inconsistency? Thanks. I'll skip a few tests in my patch in the mean time.
(Fixing summary since it was my patch that triggers the prompt repeatedly)
Summary: NSS-implemented OSKeyStore prompts master passsword for four times before rejection → NSS-implemented OSKeyStore promises does not reject after hitting cancel on master passsword prompt
I ended up workaround this in bug 1486954 so perhaps this is not that urgent.
So there are a couple things here: 1) The build system didn't properly detect Linux and thus didn't use libsecret as it should've. 2) The NSS key store backend didn't return correct errors. 3) The LibSecret keystore unlock didn't work properly and hence returned the wrong error code. Unfortunately we can't test most of the behaviours :( I'll prepare a fix.
Assignee: nobody → franziskuskiefer
This fixes issues with the NSS and LibSecret keystore not correctly rejecting unlocking of the key store. It also fixes the build to correctly detect Linux.
Priority: -- → P1
Assignee: franziskuskiefer → nobody
Priority: P1 → P3
Whiteboard: [psm-assigned] → [psm-backlog] [psm-wouldtake]
Flags: needinfo?(franziskuskiefer) → needinfo?(dkeeler)
Assignee: nobody → kjacobs.bugzilla
Status: NEW → ASSIGNED
Attachment #9014364 - Attachment description: Bug 1492305 - fix pkg-config; libsecret unlocking; NSS unlock return values → Bug 1492305 - Fix LibSecret unlocking & NSS return values
You need to log in before you can comment on or make changes to this bug.