Closed
Bug 1492316
Opened 6 years ago
Closed 5 years ago
[wpt-sync] Sync PR 13061 - Sub-sample accurate start for ABSN
Categories
(Core :: Web Audio, enhancement, P4)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 13061 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13061 Details from upstream follow. Raymond Toy <rtoy@chromium.org> wrote: > Sub-sample accurate start for ABSN > > Implement sub-sample accurate start for AudioBufferSourceNode. > Previously, if the start time was between sample boundaries, we would > start the output at the frame before the start time. This is actually > incorrect because we haven't actually started yet. We should start > the output at the next boundary, and interpolating the value based on > the true start time and the sample boundary. > > Many tests needed to be updated. Basically for each test that needed > to be changed, the sample rate is set to a power of two and all ABSN > sources are updated to make sure the source starts exactly on a frame > boundary. We also took the opportunity to adjust the error thresholds > for the tests in case lower values could be used. > > Some additional notes for the tests: > > audiobuffersource-playbackrate-zero.html: Add new test to make sure > sub-sample accurate start handles a zero playback rate. > > audiobuffersource-loop-points.html: add some code to save the actual > output. This is needed because a new reference file is needed since > the sample rate has changed. > > Also manually tested all of the modified tests with Firefox nightly. > They all pass still (except for the new sub-sample test because > Firefox doesn't do sub-sample accurate start/stop). > > Bug: 876917 > Test: the-audiobuffersourcenode-interface/sub-sample-scheduling.html > Change-Id: Ib13ba30eaa160cfd10739feabac961bf074ee309 > Reviewed-on: https://chromium-review.googlesource.com/1212270 > WPT-Export-Revision: 2265aca2ce8b9f8bdbed725db53e52d7e5f3b108
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → Web Audio
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c426317c70e31bdd40d8fdc55cd7e3034ba10b7
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf37899c6a951074db3d9a1b54e6f25f512a54e4
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7f2732d7d6bd746a278034698405d4fb3c88469
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=27ba760ffcc9b9b879dd8d2ff44b1d2b69857f79
Assignee | ||
Comment 5•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=891b4d534a00f9c15208a8959396f43c39d3ea10
Assignee | ||
Comment 6•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1596d66b57e11c5a18de07d7d116f60267514fc0
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 7•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ab25f8e4279e327bdee50ddc8d5b4f99a869a04
Assignee | ||
Comment 8•5 years ago
|
||
Ran 21 tests and 949 subtests OK : 21 PASS : 939 FAIL : 10 New tests that have failures or other problems: /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero.html # AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed.: FAIL < [subsample start with playback rate 0] 2 out of 2 assertions were failed.: FAIL X output[0:27]: Expected 0 for all values but found 1 unexpected values: Index Actual [27] 5: FAIL X output[28:]: Expected 5 for all values but found 8164 unexpected values: Index Actual [0] 6 [1] 7 [2] 8 [3] 9 ...and 8160 more errors.: FAIL /webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-panning.html # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.: FAIL < [stereo-test] 2 out of 4 assertions were failed.: FAIL X Stereo: Left channel error magnitude is not less than or equal to 9.8015e-8. Got 1.284317301397664e-7.: FAIL X Stereo: Right channel error magnitude is not less than or equal to 9.8015e-8. Got 1.0266453775997775e-7.: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/41882ed30811 [wpt PR 13061] - Sub-sample accurate start for ABSN, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/11cda6547541 [wpt PR 13061] - Update wpt metadata, a=testonly
Comment 10•5 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd641d1e2ca [wpt PR 13061] - Sub-sample accurate start for ABSN, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/8da31a6aa79d [wpt PR 13061] - Update wpt metadata, a=testonly
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5dd641d1e2ca
https://hg.mozilla.org/mozilla-central/rev/8da31a6aa79d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•